Bug 267450 - security/nuclei: Updating to 2.7.8
Summary: security/nuclei: Updating to 2.7.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/projectdiscovery/n...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-31 01:40 UTC by Gabriel M. Dutra
Modified: 2022-11-04 17:53 UTC (History)
1 user (show)

See Also:


Attachments
Updating to 2.7.8 (1.23 KB, patch)
2022-10-31 01:40 UTC, Gabriel M. Dutra
dutra: maintainer-approval+
Details | Diff
patch (1.41 KB, patch)
2022-11-02 02:58 UTC, Gabriel M. Dutra
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel M. Dutra freebsd_committer freebsd_triage 2022-10-31 01:40:25 UTC
Created attachment 237740 [details]
Updating to 2.7.8

Portlint: no errors

13.0-RELEASE-p13 amd64
13.0-RELEASE-p13 i386
13.1-RELEASE-p2 amd64
13.1-RELEASE-p2 i386
14.0-CURRENT amd64
14.0-CURRENT i386
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-31 20:50:16 UTC
Does not build on 12.3-RELEASE-p7 i386:

(...)
# github.com/projectdiscovery/nuclei/v2/pkg/utils/ratelimit
pkg/utils/ratelimit/ratelimit.go:59:13: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in struct literal (overflows)
pkg/utils/ratelimit/ratelimit.go:60:13: cannot use math.MaxInt64 (untyped int constant 9223372036854775807) as int value in struct literal (overflows)
os
(...)

nuclei-2.7.7 builds fine. Could you check it?

Cheers
Comment 2 Gabriel M. Dutra freebsd_committer freebsd_triage 2022-11-02 02:58:34 UTC
Created attachment 237800 [details]
patch

Hi, Nuno!

nuclei is supported only 64 bits architecture. I'm sending a new patch.


Report:

Portlint: no errors

Tested on

13.0-RELEASE-p13 amd64
13.1-RELEASE-p2 amd64
14.0-CURRENT amd64
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2022-11-02 13:45:56 UTC
(In reply to Gabriel M. Dutra from comment #2)

Strange, 2.7.8 assets shows:

nuclei_2.7.8_windows_amd64.zip
nuclei_2.7.8_linux_arm64.zip
nuclei_2.7.8_linux_amd64.zip
*nuclei_2.7.8_linux_armv6.zip*
nuclei_2.7.8_macOS_amd64.zip
nuclei_2.7.8_macOS_arm64.zip
*nuclei_2.7.8_linux_386.zip*
*nuclei_2.7.8_windows_386.zip*

It should build on armv6 (armv7?) and i386

What you think?
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-11-03 20:28:30 UTC
(In reply to Nuno Teixeira from comment #3)
(...)

I will open an issue about broken in i386 and commit this update with:

NOT_FOR_ARCHS= i386
NOT_FOR_ARCHS_REASON= "error short detail" # issue

Are you ok with that?

This way we can move forward port update with no more delay.

Thanks
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2022-11-03 21:52:42 UTC
(In reply to Nuno Teixeira from comment #4)
(...)

https://github.com/projectdiscovery/nuclei/issues/2801
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2022-11-04 17:45:28 UTC
(In reply to Nuno Teixeira from comment #5)

https://github.com/projectdiscovery/ratelimit/issues/4

Is the important one. I will add this issue on 32 bit arch broken reason.
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-11-04 17:52:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2e9c145837084369d57c4ae4dbfd61ce69cf6768

commit 2e9c145837084369d57c4ae4dbfd61ce69cf6768
Author:     Gabriel M. Dutra <0xdutra@gmail.com>
AuthorDate: 2022-11-04 17:48:55 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-11-04 17:48:55 +0000

    security/nuclei: Update to 2.7.8

     - only build on 64 bit archs, 32 bit issue being solved at:
       https://github.com/projectdiscovery/ratelimit/issues/4

    ChangeLog: https://github.com/projectdiscovery/nuclei/releases/tag/v2.7.8

    PR:             267450

 security/nuclei/Makefile |  5 ++++-
 security/nuclei/distinfo | 10 +++++-----
 2 files changed, 9 insertions(+), 6 deletions(-)
Comment 8 Nuno Teixeira freebsd_committer freebsd_triage 2022-11-04 17:53:03 UTC
Committed, thanks!