Created attachment 237801 [details] Patch for multimedia/gstreamer1-plugins-resindvd/Makefile After fixes to bugs 267132 and 2617100, trying to upgrade gstreamer1-plugins-core fails when it tries to install dependency multimedia/gstreamer1-plugins-resindvd. Fixing multimedia/gstremer1-plugins-dts simply allowed the build of gstreamer1-plugins-core to get a little further before dying here. System: FreeBSD XXX.XXX 12.3-STABLE FreeBSD 12.3-STABLE stable/12-n234844-5746abf94eb GENERIC amd64 Error: sys/v4l2codecs/meson.build:38:2: ERROR: Unknown variable "gstcodecs_dep". A full log can be found at /usr/ports/multimedia/gstreamer1-plugins-resindvd/work/gst-plugins-bad-1.20.3/_build/meson-logs/meson-log.txt ===> Script "configure" failed unexpectedly. Since this is remarkably similar to the failure of gstreamer1-plugins-dts fixed by 267132, I tried applying the same fix as in git commit 629aa01a, and that allowed it to complete. I will attach a patch, which if applied to multimedia/gstreamer1-plugins-resindvd/Makefile, fixes the problem for me.
I'll note that when I opened bug 267132,I had already noted that gstreamer1-plugins-resindvd failed with the same error. Fortunately, it is fixed by the same fix.
@Riggs this looks like the issue in bug 267132 with the same fix, are you able to take this?
@Russo For future reports where the issue was reported in a prior issue, but may have been missed in the resolution on close, you are welcome to re-open the issue, saving duplicate issue create and additional time/effort :) What I'll do here is re-open bug 267132 and depend on this issue, so its clear that this needs resolving to close that
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6ff8606f00d2d368d6dd2d3e7535d1c1525f59bf commit 6ff8606f00d2d368d6dd2d3e7535d1c1525f59bf Author: Thomas Zander <riggs@FreeBSD.org> AuthorDate: 2022-11-02 08:28:31 +0000 Commit: Thomas Zander <riggs@FreeBSD.org> CommitDate: 2022-11-02 21:50:38 +0000 multimedia/gstreamer1-*: Fix plugin building in dirty environments This should solve (fingers crossed) the meson autodetection problem for the remaining plugins from the "bad" set when building in dirty environments. PR: 267132, 267510 multimedia/gstreamer1-plugins-dts/Makefile | 2 +- multimedia/gstreamer1-plugins/Makefile.common | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)