Bug 267523 - graphics/gd: enable AVIF by default
Summary: graphics/gd: enable AVIF by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2022-11-02 14:29 UTC by Jan Beich
Modified: 2022-11-14 09:40 UTC (History)
1 user (show)

See Also:
dinoex: maintainer-feedback+

Attachments
v1 (apply via "git am") (1.00 KB, patch)
2022-11-02 14:29 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2022-11-02 14:29:38 UTC 
Created attachment 237817 [details]
v1 (apply via "git am")

*.avif are supported by Firefox and Chromium. AVIF option doesn't pull lang/rust as build-only dependency because RAV1E in graphics/libavif is disabled by default (at least until librav1e becomes more efficient). Besides, after bug 263185 + bug 267520 lang/rust is already pulled via graphics/libimagequant.

This partially reverts ports 1370414543ae.
Comment 1 Dirk Meyer freebsd_committer freebsd_triage 2022-11-09 20:52:52 UTC 
testing
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2022-11-10 06:39:21 UTC 
> lang/rust is already pulled via graphics/libimagequant.
Since you're at it Dirk, please consider disabling LIQ option by default because of the `lang/rust' abomination, so we all can drop our local patches (hard to keep them around with Git due to its lack of automerge).
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-11-10 08:28:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=84531028a86540f4e90c04180d1aef1fd9837fc1

commit 84531028a86540f4e90c04180d1aef1fd9837fc1
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2022-11-10 08:27:32 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2022-11-10 08:27:32 +0000

    graphics/gd: enable option AVIF as default

    PR: 267523

 graphics/gd/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 4 Dirk Meyer freebsd_committer freebsd_triage 2022-11-10 08:35:59 UTC 
Commited thanks.

There is no need for local patches.
just disable the option in /etc/make.conf or in environment of your build.

/etc/make.conf:
grahics_gd_UNSET+=AVIL LIQ
Comment 5 Alexey Dokuchaev freebsd_committer freebsd_triage 2022-11-10 14:21:54 UTC 
(In reply to Dirk Meyer from comment #4)
> /etc/make.conf:
> grahics_gd_UNSET+=AVIL LIQ
That should do it, thanks.  OTOH, people might not know about this trick or find out only when their CPU cycles and RAM being eaten by oxidation.  Is LIQ option really that commonly useful to be enabled by default in the first place?
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-11-14 09:40:27 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=896a897422773c6615a48d71b22eeee8f9de317d

commit 896a897422773c6615a48d71b22eeee8f9de317d
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2022-11-14 09:39:33 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2022-11-14 09:39:33 +0000

    graphics/gd: mark option AVIF as broken

    PR: 267523

 graphics/gd/Makefile | 1 +
 1 file changed, 1 insertion(+)