Bug 267579 - net/foreman-proxy: update to 3.4.0
Summary: net/foreman-proxy: update to 3.4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Guangyuan Yang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-05 21:28 UTC by Frank Wall
Modified: 2022-11-10 20:47 UTC (History)
2 users (show)

See Also:
freebsd: maintainer-feedback+

Attachments
update foreman-proxy to 3.4.0 (7.14 KB, text/plain)
2022-11-05 21:28 UTC, Frank Wall 		no flags Details
update foreman-proxy to 3.4.0 (v2) (6.89 KB, patch)
2022-11-07 22:36 UTC, Frank Wall 		no flags Details | Diff
update foreman-proxy to 3.4.0 (v3) (15.33 KB, patch)
2022-11-09 23:58 UTC, Frank Wall 		no flags Details | Diff
output of portlint -C (104 bytes, text/plain)
2022-11-10 00:00 UTC, Frank Wall 		no flags Details
output of poudriere (35.97 KB, text/plain)
2022-11-10 00:00 UTC, Frank Wall 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Wall 2022-11-05 21:28:30 UTC 
Created attachment 237879 [details]
update foreman-proxy to 3.4.0

This patch updates foreman-proxy to the most recent version 3.4.0 and applies the following changes:

* use daemon(1) because daemonize support is deprecated [1]
* add upgrade message to pkg-message
* add new dependency www/rubygem-webrick

[1] https://github.com/theforeman/smart-proxy/pull/777
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2022-11-05 21:28:30 UTC 
Maintainer informed via mail
Comment 2 Frank Wall 2022-11-05 21:33:16 UTC 
Release Notes for Foreman 3.4:
https://theforeman.org/manuals/3.4/index.html#Releasenotesfor3.4
Comment 3 Guangyuan Yang freebsd_committer freebsd_triage 2022-11-07 04:33:36 UTC 
Looks like plist issue:

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: etc/rc.d/foreman-proxy
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/net/foreman-proxy

Full log: http://jenkins.ygy.io/job/freebsd-ports-testing-13.1R-amd64/2116/console
Comment 4 Frank Wall 2022-11-07 22:36:43 UTC 
Created attachment 237930 [details]
update foreman-proxy to 3.4.0 (v2)
Comment 5 Frank Wall 2022-11-07 22:37:14 UTC 
> Looks like plist issue:

Oops, sorry. I've missed the poudriere warning. Now fixed in patch v2.
Comment 6 Frank Wall 2022-11-09 23:58:22 UTC 
Created attachment 237984 [details]
update foreman-proxy to 3.4.0 (v3)
Comment 7 Frank Wall 2022-11-09 23:59:32 UTC 
I've tried to apply some lessons from the Porter's Handbook:

* changed Bugzilla e-mail address to match maintainer address
* regenerated all patches using `make makepatch`
* prefixed absolute paths in Makefile with ${DESTDIR}
* regenerated patch using `git format-patch main`
* attached portlint and poudriere logs
Comment 8 Frank Wall 2022-11-10 00:00:08 UTC 
Created attachment 237985 [details]
output of portlint -C
Comment 9 Frank Wall 2022-11-10 00:00:28 UTC 
Created attachment 237986 [details]
output of poudriere
Comment 10 Guangyuan Yang freebsd_committer freebsd_triage 2022-11-10 05:36:59 UTC 
Thanks! In the future, there is no need to upload the output from portlint/poudriere, simply stating that it passed is good enough. :)
Comment 11 commit-hook freebsd_committer freebsd_triage 2022-11-10 17:18:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ead99507a41eea8951fad445d9cda7f85d98d4c0

commit ead99507a41eea8951fad445d9cda7f85d98d4c0
Author:     Frank Wall <freebsd@moov.de>
AuthorDate: 2022-11-10 17:17:16 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2022-11-10 17:17:16 +0000

    net/foreman-proxy: Update to 3.4.0

    Changelog:      https://theforeman.org/manuals/3.4/index.html#Releasenotesfor3.4

    PR:             267579

 net/foreman-proxy/Makefile                               | 16 ++++++++--------
 net/foreman-proxy/distinfo                               |  6 +++---
 net/foreman-proxy/files/foreman-proxy.in                 |  4 +++-
 net/foreman-proxy/files/patch-bin-smart-proxy            |  2 +-
 .../files/patch-config-settings.yml.example (gone)       | 11 -----------
 ...ig_settings.d_puppet__proxy__puppet__api.yml.example} |  6 +++---
 ...tings.d_puppetca__hostname__whitelisting.yml.example} |  4 ++--
 ...ch-config_settings.d_puppetca__http__api.yml.example} |  4 ++--
 ..._settings.d_puppetca__puppet__cert.yml.example (gone) |  9 ---------
 ...> patch-config_settings.d_realm__freeipa.yml.example} |  5 +++--
 ....example => patch-config_settings.d_tftp.yml.example} |  4 ++--
 .../files/patch-lib_proxy_http__download.rb              |  6 +++---
 net/foreman-proxy/pkg-message                            | 12 +++++-------
 net/foreman-proxy/pkg-plist                              |  5 -----
 14 files changed, 35 insertions(+), 59 deletions(-)