Created attachment 238080 [details] Whole cad/PrusaSlicer directory Update to PrusaSlicer 2.5.0 Issues: - files/patch-src_occt__wrapper_CMakeLists.txt is it correct to use CMAKE_INSTALL_PREFIX as replacement of hardcoded /usr/local? - files/patch-patch-src_slic3r_GUI_GUI__App.cpp Current wx32-gtk3-3.2.1 segfaults on wxString() call without args, it crashes in /usr/src/contrib/llvm-project/libcxx/include/string:2426 (freebsd 13.1p3). I didn't find a solution except commenting out the block of searching of best translation and and set translation to NULL. But it works well.
*** Bug 267771 has been marked as a duplicate of this bug. ***
Hi Teodor, Would you please provide a patch for the port instead of updating the whole directory?
Created attachment 238092 [details] Diff to previous version
Thanks for that. ^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. ^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval. -- Attachment -> Details -> maintainer-approval [+] Thanks!
Release notes are incorporated in github's release page and I'm not able find them as separate list :( https://github.com/prusa3d/PrusaSlicer/releases
Triage: severity reduced, to what's normal for an update to a port. (In reply to teodorsigaev@gmail.com from comment #5) With 2.3.3_9 most recent at <https://www.freshports.org/cad/PrusaSlicer/#history>, the closest I can get with GitHub is <https://github.com/prusa3d/PrusaSlicer/compare/version_2.3.3...version_2.5.0>. FreshPorts is our friend. Home page <https://www.prusa3d.com/prusaslicer/> redirects to <https://www.prusa3d.com/page/prusaslicer_424/> with a link to a change log at <https://files.prusa3d.com/?latest=slicer-stable&lng=en>. <https://files.prusa3d.com/?latest=slicer-stable> is not language-specific and may be more appropriate (there's a menu of languages, near top right).
Fails in poudriere: Error: Orphaned: bin/OCCTWrapper.so Error: Orphaned: lib/udev/rules.d/90-3dconnexion.rules Error: Orphaned: share/icons/hicolor/128x128/apps/PrusaSlicer-gcodeviewer.png Error: Orphaned: share/icons/hicolor/128x128/apps/PrusaSlicer.png Error: Orphaned: share/icons/hicolor/192x192/apps/PrusaSlicer-gcodeviewer.png Error: Orphaned: share/icons/hicolor/192x192/apps/PrusaSlicer.png Error: Orphaned: share/icons/hicolor/32x32/apps/PrusaSlicer-gcodeviewer.png Error: Orphaned: share/icons/hicolor/32x32/apps/PrusaSlicer.png ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 Would you mind checking it?
Hm, I don't see such error. Even on new virtual box. Could you provide more details?
(In reply to teodorsigaev@gmail.com from comment #8) It is good practice to test the port with a tool like poudriere[1]. Poudriere provides a clean environment in which the port is built. The error is saying that the port is installing those files, but then they are not listed in pkg-plist. So someone installing the port and then deinstalling it would have some leftovers in their systems. In your patch there are no changes in pkg-plist. Cheers. [1] https://docs.freebsd.org/en/books/porters-handbook/book/#porting-testing
Hmm, will try, thank you By the way, pkg-plist was significantly reduced in 16f0841, may be it was did wrongly
(In reply to teodorsigaev@gmail.com from comment #10) In that case you should have received pkg-fallout messages, but there are none: https://lists.freebsd.org/archives/freebsd-pkg-fallout/2022-November/
Created attachment 238149 [details] v2 diff Changes: - OCCTWrapper.so moved to lib/ instead of bin and added to pkg-list - 90-3dconnexion.rules is prevented from installation - FreeBD doesn't support udev machinery - share/icons/hicolor/* are add in pkg-plist. Seems, they are needed for some desktop enviroment
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3d8cf46cdbe30af59931532b4c7c95bd44e801da commit 3d8cf46cdbe30af59931532b4c7c95bd44e801da Author: teodorsigaev@gmail.com <teodorsigaev@gmail.com> AuthorDate: 2022-11-17 21:57:32 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-11-18 16:13:31 +0000 cad/PrusaSlicer: update to 2.5.0 ChangeLog: https://www.freshports.org/cad/PrusaSlicer/ PR: 267772 Reported by: teodorsigaev@gmail.com (maintainer) cad/PrusaSlicer/Makefile | 10 +- cad/PrusaSlicer/distinfo | 6 +- cad/PrusaSlicer/files/patch-CMakeLists.txt | 34 +- .../files/patch-cmake_modules_FindOpenVDB.cmake | 21 +- .../files/patch-cmake_modules_FindTBB.cmake (gone) | 738 --------------------- cad/PrusaSlicer/files/patch-src_CMakeLists.txt | 6 +- .../files/patch-src_avrdude_libavrdude.h | 2 +- cad/PrusaSlicer/files/patch-src_avrdude_main.c | 2 +- .../files/patch-src_hidapi_CMakeLists.txt | 2 +- .../files/patch-src_hidapi_libusb_hid.c | 2 +- .../files/patch-src_hints_HintsToPot.cpp (new) | 10 + .../files/patch-src_libslic3r_CMakeLists.txt | 4 +- .../files/patch-src_libslic3r_Platform.cpp | 4 +- .../files/patch-src_libslic3r_Platform.hpp | 18 +- .../files/patch-src_libslic3r_Print.cpp (gone) | 29 - .../files/patch-src_libslic3r_PrintBase.cpp (gone) | 11 - .../files/patch-src_libslic3r_PrintBase.hpp (gone) | 118 ---- .../patch-src_libslic3r_PrintObject.cpp (gone) | 10 - .../files/patch-src_libslic3r_SLAPrint.cpp (gone) | 47 -- .../patch-src_libslic3r_SLA_Concurrency.hpp (gone) | 20 - .../patch-src_libslic3r_SLA_SupportTree.cpp (gone) | 12 - .../patch-src_libslic3r_SupportMaterial.cpp (gone) | 10 - .../files/patch-src_libslic3r_Thread.cpp (gone) | 41 -- .../files/patch-src_libslic3r_pchheader.hpp (gone) | 15 - .../files/patch-src_libslic3r_utils.cpp (gone) | 22 - .../patch-src_occt__wrapper_CMakeLists.txt (new) | 22 + .../files/patch-src_qhull_CMakeLists.txt | 8 +- .../files/patch-src_slic3r_CMakeLists.txt | 16 +- ..._slic3r_GUI_BackgroundSlicingProcess.cpp (gone) | 29 - ..._slic3r_GUI_BackgroundSlicingProcess.hpp (gone) | 11 - .../files/patch-src_slic3r_GUI_GUI__App.cpp (new) | 19 + .../files/patch-src_slic3r_GUI_InstanceCheck.cpp | 4 +- .../patch-src_slic3r_GUI_InstanceCheck.hpp (gone) | 11 - ...tch-src_slic3r_GUI_Mouse3DController.cpp (gone) | 154 ----- ...tch-src_slic3r_GUI_Mouse3DController.hpp (gone) | 49 -- .../files/patch-src_slic3r_GUI_OpenGLManager.cpp | 4 +- ...src_slic3r_GUI_RemovableDriveManager.cpp (gone) | 104 --- ...src_slic3r_GUI_RemovableDriveManager.hpp (gone) | 23 - ...a.cpp => patch-tests_fff__print_test__data.cpp} | 11 +- cad/PrusaSlicer/pkg-plist | 7 + 40 files changed, 137 insertions(+), 1529 deletions(-)
(In reply to Fernando Apesteguía from comment #13) Thank you very much!
Thanks ---- Release notes ============= Comment #6 gave: <https://files.prusa3d.com/?latest=slicer-stable> More accurately, for 2.5.0: <https://files.prusa3d.com/?latest=slicer-stable#post-1439>
(In reply to Graham Perrin from comment #16) Version in quarterly is 2.3.3. MFH a 2.5.0 will ensure a big surprise for users which is not what users in quarterly expect.