Bug 267794 - www/elinks: Patch out "user torturation" code
Summary: www/elinks: Patch out "user torturation" code
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-15 19:59 UTC by Dustin Marquess
Modified: 2022-11-21 10:08 UTC (History)
3 users (show)

See Also:

Attachments
user toruturization disable patch (2.16 KB, patch)
2022-11-15 20:00 UTC, Dustin Marquess 		jailbird: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dustin Marquess 2022-11-15 19:59:45 UTC 
The "user torturation" code from over 17 years ago is considered abusive.

This patch disables it and also fixes a typo in the Makefile while we're at it.

Submitted upstream at https://github.com/rkd77/elinks/pull/197
Comment 1 Dustin Marquess 2022-11-15 20:00:17 UTC 
Created attachment 238102 [details]
user toruturization disable patch
Comment 2 Dustin Marquess 2022-11-15 20:43:25 UTC 
Upstream merged in the PR.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-11-16 15:35:45 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6b82b9945652f28f4245dd2e2662af401cda0534

commit 6b82b9945652f28f4245dd2e2662af401cda0534
Author:     Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2022-11-16 15:30:51 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2022-11-16 15:34:49 +0000

    www/elinks: fix detection of execinfo

    When moving from autotools to autotools to meson, the check from
    the execinfo header was lost, readd this test.

    When execinfo is not detected, the replacement code instead of error
    is an abusive end less loop, while here patch out this part [1].

    Note that upstream merge the removal of the code.

    While here remove a useless macro which wasn't functional anyway due to
    a typo

    PR:     267794 [1]
    Submitted by:   Dustin Marquess <jailbird@fdf.net> [1]

 www/elinks/Makefile                           |  2 +-
 www/elinks/files/patch-meson.build            | 11 ++++++++++
 www/elinks/files/patch-src_util_error.c (new) | 29 +++++++++++++++++++++++++++
 3 files changed, 41 insertions(+), 1 deletion(-)
Comment 4 Juraj Lutter freebsd_committer freebsd_triage 2022-11-16 21:48:42 UTC 
Regarding the commit above, seems that ninja (meson) does not honor LIBS, so -lexecinfo should be moved from LIBS to LDFLAGS. Tested on 13.1-RELEASE.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-11-21 07:07:53 UTC 
^Triage: Assigning to committer who resolved the issue.

otis@, could you please open a separate PR for the LIBS issue?

Thanks!
Comment 6 Juraj Lutter freebsd_committer freebsd_triage 2022-11-21 10:08:23 UTC 
I've reported that on IRC and it's been silently fixed in commit c08875b23f3e80f11edee8479b293a2bf5cd1113