Bug 267851 - databases/postgresql-promscale: fails to build after rust 1.65.0
Summary: databases/postgresql-promscale: fails to build after rust 1.65.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Felder
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-18 15:17 UTC by Jony Hudson
Modified: 2023-01-25 17:03 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (feld)


Attachments
testport build log (82.47 KB, text/plain)
2022-11-18 15:17 UTC, Jony Hudson
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jony Hudson 2022-11-18 15:17:49 UTC
Created attachment 238163 [details]
testport build log

The build at HEAD fails with:

The application panicked (crashed).
Message:  No control file found
Location: /wrkdirs/usr/ports/databases/postgresql-promscale/work/pgx/pgx-utils/src/sql_entity_graph/pgx_sql.rs:137

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ SPANTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

   0: pgx_utils::sql_entity_graph::pgx_sql::build with extension_name="promscale" versioned_so=true force_create_or_replace=true
      at pgx-utils/src/sql_entity_graph/pgx_sql.rs:81
   1: cargo_pgx::command::schema::generate_schema with pg_version=13.13 release=true test=false features=["serde_json", "proptest", "pg13"]
      at cargo-pgx/src/command/schema.rs:145
   2: cargo_pgx::command::schema::execute
      at cargo-pgx/src/command/schema.rs:84

If I roll my ports tree back to the commit before the rust update (f685554243aefbc990c8765872afd2c83dc7bfc9) it builds fine.

Poudriere testport log attached.

I don't have any insight yet into what the problem actually is!
Comment 1 Mark Felder freebsd_committer freebsd_triage 2022-12-03 18:42:43 UTC
This bug is being caused by pgx, the rust postgres extension builder. Upstream has fixed this issue by updating their pgx version but as they only ship prebuilt binaries built in a controlled environment they have not made a new release yet. I will see if I can get this backported as there's no ETA on the next release yet.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-01-05 23:25:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=abdf96d348b9d60575e7a130691108853f881080

commit abdf96d348b9d60575e7a130691108853f881080
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-01-05 23:23:33 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-01-05 23:25:20 +0000

    databases/postgresql-promscale: Mark as BROKEN

    Fails to build using Rust 1.65.0 or newer

    PR:             267851
    Reported by:    Jony Hudson <bsd@j-star.org>

 databases/postgresql-promscale/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 3 Mark Felder freebsd_committer freebsd_triage 2023-01-18 18:32:25 UTC
I have local updates to timescaledb, postgresql-promscale, and promscale which builds with the latest Rust in ports, but this relies on timescaledb being updated too so I'm just waiting on permission from kbowling to update the timescaledb port
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-01-25 17:01:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=880ce9772bb0dee312c984d2d428f7bc51bf22dd

commit 880ce9772bb0dee312c984d2d428f7bc51bf22dd
Author:     Mark Felder <feld@FreeBSD.org>
AuthorDate: 2023-01-25 16:58:33 +0000
Commit:     Mark Felder <feld@FreeBSD.org>
CommitDate: 2023-01-25 17:00:46 +0000

    databases/postgresql-promscale: Update to 0.8.0

    Changelog:      https://github.com/timescale/promscale_extension/releases/tag/0.8.0

    PR:     267851

 databases/postgresql-promscale/Makefile            |  29 +-
 databases/postgresql-promscale/crates.mk           | 268 +++++-----
 databases/postgresql-promscale/distinfo            | 546 +++++++++++----------
 .../postgresql-promscale/files/patch-Cargo.toml    |  14 +-
 ...ch-cargo-crates_pgx-pg-sys-0.6.1_build.rs (new) |  10 +
 .../files/pgx-include-patch (gone)                 |  10 -
 databases/postgresql-promscale/pkg-plist           |  39 +-
 7 files changed, 476 insertions(+), 440 deletions(-)