Created attachment 238228 [details] patch adding -Wdate-time Originally committed as 489d7a8528ca but reverted as it leaked into some ports builds, causing them to fail. Now available with an opt-out flag that those ports could set. See https://reviews.freebsd.org/D29580
Some new failure logs: https://pkg-status.freebsd.org/gohan05/data/mainamd64PR267902-default/2022-11-22_10h24m57s/logs/errors/linux_libusb-13.1.0.log https://pkg-status.freebsd.org/gohan05/data/mainamd64PR267902-default/2022-11-22_10h24m57s/logs/errors/skem-1.0.2_2.log https://pkg-status.freebsd.org/gohan05/data/mainamd64PR267902-default/2022-11-22_10h24m57s/logs/errors/urelay-1.0.log https://pkg-status.freebsd.org/gohan05/data/mainamd64PR267902-default/2022-11-22_10h24m57s/logs/errors/unquote-1.0.b4.log
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=39ab5e3879edef7f7065fd429a3c818f292ed270 commit 39ab5e3879edef7f7065fd429a3c818f292ed270 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2022-11-25 19:03:00 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2022-11-25 19:14:55 +0000 net/urelay: disable date/time nonreproducible build warning The base system build infrastructure will add -Wdate-time, to avoid use of nonreproducible __DATE__ and __TIME__ in the base system. This port makes use of the base system build infrastructure as well as __DATE__ and/or __TIME__, so explicitly opt out of the warning. PR: 267902 [exp-run] Approved by: jrm Sponsored By: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D37505 net/urelay/Makefile | 2 ++ 1 file changed, 2 insertions(+)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=91463de0b0fba41a1c19aafa57638faa4c74f47d commit 91463de0b0fba41a1c19aafa57638faa4c74f47d Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2022-11-25 19:05:15 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2022-11-25 19:15:33 +0000 sysutils/unquote: disable date/time nonreproducible build warning The base system build infrastructure will add -Wdate-time, to avoid use of nonreproducible __DATE__ and __TIME__ in the base system. This port makes use of the base system build infrastructure as well as __DATE__ and/or __TIME__, so explicitly opt out of the warning. PR: 267902 [exp-run] Approved by: jrm Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D37504 sysutils/unquote/Makefile | 1 + 1 file changed, 1 insertion(+)
devel/linux_libusb issue is slightly different - it looks like it must use a GCC that does not support -Wdate-time, rather than producing the date/time warning during the build. > gcc: error: unrecognized command line option '-Wdate-time' But setting NO_WDATE_TIME should still be adequate to address that case.
devel/linux_libusb: https://reviews.freebsd.org/D37506 mail/milter-skem: https://reviews.freebsd.org/D37507
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c43b10698c7c6e2ee361632b571ac7fbf80feb84 commit c43b10698c7c6e2ee361632b571ac7fbf80feb84 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2022-11-25 19:22:54 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2022-11-30 18:56:31 +0000 devel/linux_libusb: disable date/time nonreproducible build warning The base system build infrastructure will add -Wdate-time, to avoid use of nonreproducible __DATE__ and __TIME__ in the base system. This port makes use of a GCC that does not support -Wdate-time, so opt out of the warning. Reviewed by: hselasky Approved by: jrm PR: 267902 [exp-run] Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D37506 devel/linux_libusb/Makefile | 1 + 1 file changed, 1 insertion(+)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b780076d6947fef9ca36a5b09755fecfbb0805ac commit b780076d6947fef9ca36a5b09755fecfbb0805ac Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2022-11-25 19:26:29 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2022-11-30 18:56:32 +0000 mail/milter-skem: disable date/time nonreproducible build warning The base system build infrastructure will add -Wdate-time, to avoid use of nonreproducible __DATE__ and __TIME__ in the base system. This port makes use of the base system build infrastructure as well as __DATE__ and/or __TIME__, so explicitly opt out of the warning. PR: 267902 [exp-run] Approved by: mi Sponsored By: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D37507 mail/milter-skem/Makefile | 1 + 1 file changed, 1 insertion(+)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=a8f92d247e77f97f70aada494210bf04f1f7ef39 commit a8f92d247e77f97f70aada494210bf04f1f7ef39 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2022-02-09 22:10:03 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2022-11-30 18:59:57 +0000 Enable -Wdate-time warning This produces an "expansion of date or time macro is not reproducible" warning or error upon use of __DATE__ or __TIME__. Provide NO_WDATE_TIME for ports or 3rd party software to opt out. This is a recommit of 489d7a8528ca, which was reverted (by baf8cbcd97a6) due to ports build failures. PR: 267902 [exp-run] Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D29580 share/mk/bsd.sys.mk | 3 +++ 1 file changed, 3 insertions(+)