Bug 267949 - security/libpwquality: update to 1.4.5
Summary: security/libpwquality: update to 1.4.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks: 264657
  Show dependency tree / graph
 
Reported: 2022-11-23 21:07 UTC by Olivier Duchateau
Modified: 2022-12-06 18:18 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (desktop)

Attachments
Patch to update security/libpwquality (3.33 KB, patch)
2022-11-23 21:07 UTC, Olivier Duchateau 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2022-11-23 21:07:20 UTC 
Created attachment 238283 [details]
Patch to update security/libpwquality

- Update to 1.4.5
- Apply OpenBSD patch (otherwise we encounter errors like bug #264657)
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-12-06 18:13:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=934e8c6541b2c9233e2df5901d466ce8fc23e668

commit 934e8c6541b2c9233e2df5901d466ce8fc23e668
Author:     Adriaan de Groot <adridg@FreeBSD.org>
AuthorDate: 2022-12-06 14:08:19 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2022-12-06 18:12:10 +0000

    x11-toolkits/qt5-gui: minimal plugin independent of option X11

    The "minimal" plugin is always needed (or just **one** of
    the plugins, but this will do) to allow QtGui applications
    to function. Turning off X11 turned them all off (I supposed
    "if you're not using X11, you must install the Wayland bits
    instead" would work, but that's hard to express in ports).

    So remove the plist-sub from the minimal plugin -- there is
    enough X11 pulled in regardless of the X11 option, that
    the plugin builds (and links against X11 libraries, so
    the option is a lie).

    The linked PR is not for this port, but demonstrates a problem:
    if X11 is turned off, there is no platform plugins at all,
    and then there is no way to run Qt-Gui applications (even with
    minimal / no graphics). For "command-line" Qt-Gui applications
    like qhelpgenerator, that is a problem.

    PR:             267949

 x11-toolkits/qt5-gui/Makefile  | 1 +
 x11-toolkits/qt5-gui/pkg-plist | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-12-06 18:13:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=61b8658122ea005efe94171f6009aa0d95ef701b

commit 61b8658122ea005efe94171f6009aa0d95ef701b
Author:     Olivier Duchateau <duchateau.olivier@gmail.com>
AuthorDate: 2022-12-06 14:15:11 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2022-12-06 18:12:10 +0000

    security/libpwquality: update to 1.4.5

    PR:             264657 267949

 security/libpwquality/Makefile                             |  7 +++++--
 security/libpwquality/distinfo                             |  6 +++---
 security/libpwquality/files/patch-python_Makefile.in (new) | 11 +++++++++++
 security/libpwquality/pkg-plist                            |  6 +++++-
 4 files changed, 24 insertions(+), 6 deletions(-)
Comment 3 Adriaan de Groot freebsd_committer freebsd_triage 2022-12-06 18:18:59 UTC 
Thanks! (The qt5-gui mention is the wrong PR, though, should have been PR #266491)