I am currently trying to reproduce this on my system. 14-CURRENT host with a 12.3 guest.

More logs:

https://portsfallout.com/fallout?port=emulators%2Fqmc2&maintainer=&env=&
category=&flavor=

${INCLUDEPATH} is not being set on build hosts <14-CURRENT

Correction fails on <13

${WRKDIR}/qmc2-mame-fe-0.243/scripts/sdl-includepath.sh produces an empty string, when it should produce the following:
/usr/local/include/SDL2
/usr/local/include

Those file paths are meant to populate ${INCLUDEPATH}.

From https://github.com/qmc2/qmc2-mame-fe/blob/master/scripts/sdl-includepath.sh:

echo $SDL_CFLAGS | egrep -o -e "\\-I\\S+" | sed -e 's/^-I//'

Appears to be failing on egrep. Prior to the pipe to egrep, ${SDL_CFLAGS} expands to:

-I/usr/local/include/SDL2 -I/usr/local/include -D_REENTRANT -D_THREAD_SAFE

I think egrep is meant to remove the -I, the trailing whitespace, and the -D_* flags.

egrep is throwing out error code 1.

egrep on the build guests <13.x is perhaps too old and does not have the expected Special Expressions found in the grep with guests ≥13.x.

12.3-RELEASE:
$ grep --version
grep (GNU grep) 2.5.1-FreeBSD

14-CURRENT:
$ grep --version
grep (BSD grep, GNU compatible) 2.6.0-FreeBSD

I do not think the GNU grep in the 12.3 build guest has the support for the \S Special Expression. I have tested the build with the following change to ${WRKDIR}/qmc2-mame-fe-0.243/scripts/sdl-includepath.sh:

echo $SDL_CFLAGS | egrep -o -e "-I[^[:space:]]+" | sed -e 's/^-I//'

The build completes.

Created attachment 238499 [details]
qmc2.patch

• Update ${RUN_DEPENDS} to reflect current mame/mess versions
• Add two more files to ${SHEBANG_FILES}
• Add ${EXTRA_PATCHES} conditional to compensate for missing \S Special Expression support in GNU grep on system <13.x (if that is even the problem)
• Add files/extra-scripts-sdl-includepaths to patch ${WRKSRC}/scripts/sdl-includepath.sh

I am waiting on the poudriere-testport to finish, I am also not sure if the attached is the correct way to solve this problem.

pourdriere-testport build passed.

Comment 11 commit-hook 2022-12-05 09:39:11 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8674ebc2a72d77bca1d4fc1438a6b986184e7c75

commit 8674ebc2a72d77bca1d4fc1438a6b986184e7c75
Author:     Alastair Hogge <agh@riseup.net>
AuthorDate: 2022-12-05 09:34:49 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-12-05 09:37:53 +0000

    emulators/qmc2: Fix build on systems <13.x: SDL.h not found

    * Update ${RUN_DEPENDS} to reflect current mame/mess versions
    * Add two more files to ${SHEBANG_FILES}
    * Add ${EXTRA_PATCHES} conditional to compensate for missing \S Special
      Expression support in GNU grep on system <13.x (if that is even the problem)
    * Add files/extra-scripts-sdl-includepaths to patch
      ${WRKSRC}/scripts/sdl-includepath.sh

    PR:             267980

 emulators/qmc2/Makefile                                   | 11 +++++++++--
 emulators/qmc2/files/extra-scripts-sdl-includepaths (new) |  9 +++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

Comment 12 Nuno Teixeira 2022-12-05 09:41:15 UTC

Nice work!

Committed, thank you!

Hi Nuno,

Thanks very much for that.