Bug 268077 - games/libretro-beetle_psx: fix build on armv7
Summary: games/libretro-beetle_psx: fix build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-30 11:07 UTC by Robert Clausecker
Modified: 2022-12-01 21:21 UTC (History)
1 user (show)

See Also:
fuz: merge-quarterly?

Attachments
games/libretro-beetle_psx: fix build on armv7 (1.44 KB, patch)
2022-11-30 11:07 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
games/libretro-beetle_psx: fix build on armv7 (2.29 KB, patch)
2022-11-30 13:07 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-11-30 11:07:26 UTC 
Created attachment 238443 [details]
games/libretro-beetle_psx: fix build on armv7

The functions __addsf3 and __adddf3 are part of libgcc which is not provided when
compiling with clang.  Fiddle with some #if directives to provide shims if we
compile with clang.

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Please MFH if possible.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-11-30 11:58:56 UTC 
Please do not commit the patch yet, I found a problem that needs further work.
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-11-30 13:07:47 UTC 
Created attachment 238452 [details]
games/libretro-beetle_psx: fix build on armv7

Updated patch compiling with gcc on arm.  See also bug #268079.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-01 19:22:08 UTC 
(In reply to Robert Clausecker from comment #2)

> Updated patch compiling with gcc on arm.  See also bug #268079.

Is this patch ok to be committed?
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2022-12-01 20:55:05 UTC 
(In reply to Nuno Teixeira from comment #3)

I believe so.  Please commit.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-12-01 21:18:03 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4b93307b9d1762c72e68c229301795c8ebdc79fc

commit 4b93307b9d1762c72e68c229301795c8ebdc79fc
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-12-01 21:12:04 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-12-01 21:17:05 +0000

    games/libretro-beetle_psx: Fix build on armv7

    The functions __addsf3 and __adddf3 are part of libgcc which is not
    provided when compiling with clang.  Fiddle with some #if directives to
    provide shims if we compile with clang.

    PR:             268077
    MFH:            2022Q4 (build fix)

 games/libretro-beetle_psx/Makefile                   | 10 ++++++++--
 .../patch-deps_lightning_lib_jit__arm-swf.c (new)    | 20 ++++++++++++++++++++
 2 files changed, 28 insertions(+), 2 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-12-01 21:21:04 UTC 
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0ad5602a2ac93edff0568c23240e77b6ccf20e17

commit 0ad5602a2ac93edff0568c23240e77b6ccf20e17
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-12-01 21:12:04 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-12-01 21:18:29 +0000

    games/libretro-beetle_psx: Fix build on armv7

    The functions __addsf3 and __adddf3 are part of libgcc which is not
    provided when compiling with clang.  Fiddle with some #if directives to
    provide shims if we compile with clang.

    PR:             268077
    MFH:            2022Q4 (build fix)
    (cherry picked from commit 4b93307b9d1762c72e68c229301795c8ebdc79fc)

 games/libretro-beetle_psx/Makefile                   | 10 ++++++++--
 .../patch-deps_lightning_lib_jit__arm-swf.c (new)    | 20 ++++++++++++++++++++
 2 files changed, 28 insertions(+), 2 deletions(-)
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-01 21:21:36 UTC 
Committed, thanks!