Bug 268089 - emulators/{mame,mess}: Update to 0.250
Summary: emulators/{mame,mess}: Update to 0.250
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://www.mamedev.org/releases/what...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-01 00:14 UTC by Alastair Hogge
Modified: 2022-12-01 23:40 UTC (History)
2 users (show)

See Also:


Attachments
mame-0.250.patch (1.30 KB, patch)
2022-12-01 04:58 UTC, Alastair Hogge
agh: maintainer-approval+
Details | Diff
mess-0.250.patch (439 bytes, patch)
2022-12-01 08:40 UTC, Alastair Hogge
agh: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alastair Hogge 2022-12-01 00:14:57 UTC

    
Comment 1 Alastair Hogge 2022-12-01 00:15:38 UTC
Waiting on poudriere-testport to finish for both mame and mess
Comment 2 Alastair Hogge 2022-12-01 04:58:32 UTC
Created attachment 238466 [details]
mame-0.250.patch

Update to 0.250
Comment 3 Alastair Hogge 2022-12-01 08:40:46 UTC
Created attachment 238468 [details]
mess-0.250.patch

Update to 0.250
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-01 14:01:53 UTC
^Triage: [TAGS] in issue Summary are deprecated
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval
Comment 5 Alastair Hogge 2022-12-01 14:48:20 UTC
(In reply to Nuno Teixeira from comment #4)

Thanks for the triage and suggestions.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-12-01 18:28:33 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b720bd5404e0320c7dc1323c1392f0f0cc4cc0ea

commit b720bd5404e0320c7dc1323c1392f0f0cc4cc0ea
Author:     Alastair Hogge <agh@riseup.net>
AuthorDate: 2022-12-01 18:23:11 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-12-01 18:26:21 +0000

    emulators/{mame,mess}: Update to 0.250

     - Don't use MAKE_JOBS_UNSAFE as no problems found in parallel building

    ChangeLog:      https://www.mamedev.org/releases/whatsnew_0250.txt
    PR:             268089

 emulators/mame/Makefile  | 4 +---
 emulators/mame/distinfo  | 6 +++---
 emulators/mame/pkg-plist | 1 +
 emulators/mess/pkg-plist | 1 +
 4 files changed, 6 insertions(+), 6 deletions(-)
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2022-12-01 18:33:05 UTC
- Don't use MAKE_JOBS_UNSAFE as no problems found in parallel building

( https://docs.freebsd.org/en/books/porters-handbook/book/#parallel-builds )

Build was tested on 140amd64, 131amd64, 123{amd64,i386} without MAKE_JOBS_UNSAFE.
If you receive errors from build servers for other archs, please post links in this PR so we can study exceptions.

Committed, thanks!
Comment 8 Alastair Hogge 2022-12-01 23:40:01 UTC
(In reply to Nuno Teixeira from comment #7)
Hi Nuno,

Thank you for committing the patches.

Great work on testing the port without ${MAKE_JOBS_UNSAFE}—I left it in with the 0.249 update (https://cgit.freebsd.org/ports/commit/emulators/mame?id=5fb3b275a32501e1df45a08b034b94b8eb93b9a2) because poudriere on my host would rarely fail, hopefully my build environment is the variable in this case.