Bug 268098 - www/npm: fails to run commands
Summary: www/npm: fails to run commands
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
: 268168 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-12-01 12:23 UTC by Guido Falsi
Modified: 2022-12-07 14:20 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
patch v1 (917 bytes, patch)
2022-12-01 12:23 UTC, Guido Falsi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2022-12-01 12:23:36 UTC 
Created attachment 238473 [details]
patch v1

Hi,

Thanks for you work on npm and many other ports!

After the recent update npm fails again to run commands with behavior similar to bug 266159

Actually upstream should have fixed the issue with recent commits, mainly [1] and adding @npmcli/promise-spawn

Removing patch-npm-run fixeds the issue as not patching is necessary anymore.


Thanks again and in advance fop future work and updates.


[1] https://github.com/npm/run-script/commit/45f2301931ba7686fa0a4b1a1d69ecc1892fdf85
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2022-12-05 16:16:20 UTC 
*** Bug 268168 has been marked as a duplicate of this bug. ***
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2022-12-05 17:25:28 UTC 
Can you commit this patch under portmgr blanket approval (Trivial and tested build and runtime fixes) ?
It fixes onlyoffice and electron.

Thank you.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2022-12-05 17:32:15 UTC 
(In reply to Mikael Urankar from comment #2)

Good idea. I admit I did not realize this was causing this much breakage in the ports tree.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-12-05 17:37:38 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cb9139ad0a3a8c3d07086ffa8926a525a3c1b1e7

commit cb9139ad0a3a8c3d07086ffa8926a525a3c1b1e7
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2022-12-05 17:34:33 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2022-12-05 17:34:33 +0000

    www/npm: Fix npm ability to run commands

    PR:             268098
    Approved by:    portmg (fixit blanket)

 www/npm/Makefile                   |  1 +
 www/npm/files/patch-npm-run (gone) | 11 -----------
 2 files changed, 1 insertion(+), 11 deletions(-)
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2022-12-05 17:38:41 UTC 
Patch committed.