Bug 268122 - devel/sdl20: track libvulkan.so dependency
Summary: devel/sdl20: track libvulkan.so dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2022-12-02 10:04 UTC by Jan Beich
Modified: 2022-12-07 19:55 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (amdmi3)

Attachments
v1 (apply via "git am") (1.04 KB, patch)
2022-12-02 10:04 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2022-12-02 10:04:45 UTC 
Created attachment 238487 [details]
v1 (apply via "git am")

Mentioned in https://blog.supertuxkart.net/2022/09/supertuxkart-14-release-candidate-1.html
supertuxkart has no references to libvulkan.so, so the dependency comes from SDL_vulkan itself.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-12-05 19:28:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=490c5ee6b0cd71d73169652f3f28a93cdbc00e5d

commit 490c5ee6b0cd71d73169652f3f28a93cdbc00e5d
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2022-12-05 18:56:10 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2022-12-05 19:28:13 +0000

    devel/sdl20: update dependencies

    - Properly register dependency on vulkan
    - Add optional client-side decorations support

    PR:             266969, 268122
    Submitted by:   jbeich

 devel/sdl20/Makefile | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2022-12-05 22:29:13 UTC 
+CSD_LIB_DEPENDS=                libdecor-0.so:x11-toolkits/libdecor
-CSD_LIB_DEPENDS=                libdecor.so:x11-toolkits/libdecor
Comment 3 Jan Beich freebsd_committer freebsd_triage 2022-12-06 06:29:36 UTC 
(In reply to VVD from comment #2)
Not my fault. attachment 237652 [details] used BUILD_DEPENDS.
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2022-12-06 08:50:55 UTC 
(In reply to Jan Beich from comment #3)
But you can fix it! ;-)
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2022-12-06 14:28:21 UTC 
Why closed? It's broken with CSD on.
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2022-12-07 19:55:31 UTC 
CSD option fixed here: https://cgit.freebsd.org/ports/commit/devel/sdl20?id=58917cf045be796bccd1afc06f481b21e560956e