While trying to build a set of packages this port fails to build when there is WITH_DEBUG=yes in make.conf. In case some logs help to fix this: https://pdr.bofh.network/data/latest-per-pkg/libgcrypt/1.9.4_1/123i386-default-DEBUG.log https://pdr.bofh.network/data/latest-per-pkg/libgcrypt/1.9.4_1/123-default-DEBUG.log https://pdr.bofh.network/data/latest-per-pkg/libgcrypt/1.9.4_1/131-default-DEBUG.log
I know exactly what the problem is. It's the inline assembly running out of registers. Because inline assembly assigns explicit registers, in DEBUG mode there are not enough registers to support both inline assembly and DEBUG. The only solution is to replace the inline assembly with C. Would you like me to do this? It will result in a performance impact. We could #ifdef out the inline assembly when the DEBUG flag is set. Would that be preferable? Otherwise there is no solution. Let me know your preference. (Personally, #ifdefing out the inline assembly when DEBUG is set defeats the purpose of DEBUG mode.) Your choice.
(In reply to Cy Schubert from comment #1) > We could #ifdef out the inline assembly when the DEBUG flag is set. Would that be preferable? I think this would be very much easy and accepted solutions. My actual source of problem is not libgcrypt but php. For php debug support we need the line WITH_DEBUG=yes and when we try to build the php with DEBUG support it fails as libgcrypt fails to build. So a quick fix would actually allow us to run php in DEBUG mode again. And eventually in DEBUG mode we do not need performance so even it has performance side-effects it's acceptable to us. Thanks in advance for your quickfix.
Created attachment 238544 [details] Try this Try this.
https://pdr.bofh.network/data/latest-per-pkg/libgcrypt/1.9.4_1/ I think all are building fine and can be committed.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c35577ebc10af5ae8c509e4c73a44a06ac5b05d4 commit c35577ebc10af5ae8c509e4c73a44a06ac5b05d4 Author: Cy Schubert <cy@FreeBSD.org> AuthorDate: 2022-12-05 15:58:23 +0000 Commit: Cy Schubert <cy@FreeBSD.org> CommitDate: 2022-12-05 19:52:37 +0000 security/libgcrypt: Circumvent WITH_DEBUG build failure Register allocation exaustion results within inline assembly when WITH_DEBUG is specified. Therefore when WITH_DEBUG is used, disable inline assembly. PR: 268173 Reported by: bofh MFH: 2022Q4 security/libgcrypt/Makefile | 4 +++ security/libgcrypt/files/patch-tests_basic.c (new) | 29 ++++++++++++++++++++++ 2 files changed, 33 insertions(+)
A commit in branch 2022Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e63d23edd8c9a7b25e5539fa7c72d2b00316aa04 commit e63d23edd8c9a7b25e5539fa7c72d2b00316aa04 Author: Cy Schubert <cy@FreeBSD.org> AuthorDate: 2022-12-05 15:58:23 +0000 Commit: Cy Schubert <cy@FreeBSD.org> CommitDate: 2022-12-05 20:06:34 +0000 security/libgcrypt: Circumvent WITH_DEBUG build failure Register allocation exaustion results within inline assembly when WITH_DEBUG is specified. Therefore when WITH_DEBUG is used, disable inline assembly. PR: 268173 Reported by: bofh (cherry picked from commit c35577ebc10af5ae8c509e4c73a44a06ac5b05d4) security/libgcrypt/Makefile | 4 +++ security/libgcrypt/files/patch-tests_basic.c (new) | 29 ++++++++++++++++++++++ 2 files changed, 33 insertions(+)
Committed and fixed.