Bug 268228 - net-im/gotosocial: upgrade to 0.6.0
Summary: net-im/gotosocial: upgrade to 0.6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/superseriousbusine...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-07 16:39 UTC by Mike Bristow
Modified: 2023-01-30 09:48 UTC (History)
5 users (show)

See Also:


Attachments
patch to update gotosocial to 0.6.0 (6.58 KB, patch)
2022-12-07 16:39 UTC, Mike Bristow
no flags Details | Diff
Different patch proposed to update net-im/gotosocial to version 0.6.0 (5.56 KB, patch)
2023-01-13 09:13 UTC, SolarCatcher
eduardo: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Bristow 2022-12-07 16:39:02 UTC
Created attachment 238607 [details]
patch to update gotosocial to 0.6.0

Hi,

I'm a little uncertain about the patch to build.sh; go is not my forte.  But I am happily using the result on my tiny fediverse instance!

Cheers,
Mike
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2022-12-07 16:39:02 UTC
Maintainer informed via mail
Comment 2 Graham Perrin freebsd_committer freebsd_triage 2022-12-08 03:59:50 UTC
Triage: severity reduced to the norm for an update to a port.
Comment 3 Mike Bristow 2023-01-03 14:54:40 UTC
The update to to go 1.19.4 breaks gotosocial; doing some reading around the problem I think it'll get fixed with 1.19.5 (but perhaps a gotosocial patch will land first)

I'll keep an eye on things, but as it stands this patch breaks the build, so please don't commit it.
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-03 15:36:01 UTC
(In reply to Mike Bristow from comment #3)
Hello,

Problem documentated here:
https://github.com/superseriousbusiness/gotosocial/commit/0871f5d18184b44c4ad7cfedf0c59a9b3736e617
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-03 15:43:03 UTC
maintainer not resgistered: me+freebsd@igalic.co

Are you the maintainer?
Comment 6 Mike Bristow 2023-01-04 10:47:04 UTC
(In reply to Nuno Teixeira from comment #5)
I am not the maintainer, just a gotosocial user :)
Comment 7 SolarCatcher 2023-01-13 09:13:44 UTC
Created attachment 239440 [details]
Different patch proposed to update net-im/gotosocial to version 0.6.0
Comment 8 SolarCatcher 2023-01-13 09:16:00 UTC
Hi Mike,

I had worked on the 0.6.0 version, too - in my private -devel branch under https://github.com/utrenkner/gotosocial-devel

I do not understand what your build.sh file does. I successfully built my 0.6.0 port without such an addition.

Therefore, I propose a slightly different patch: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=239440&action=diff
Comment 9 Mina Galić freebsd_triage 2023-01-13 10:38:03 UTC
first off: how did i miss this entire conversation?

secondly: I like Uwe's patch a little better — because it makes so without modifying biild.sh
Mike,can you explain why that seemed necessary?
Comment 10 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-13 12:25:12 UTC
(In reply to Mina Galić from comment #9)

Seems to have some problem with maintainer email:

Maintainer 	Total Ports 	Ports with New Distfile(s) 	% Out of Date
me+freebsd@igalic.co	2	1	50.00%
me@igalic.co	1	1	100.00%

https://portscout.freebsd.org/me+freebsd@igalic.co.html
https://portscout.freebsd.org/me@igalic.co.html

Since your bugzilla email is me@igalic.co, then we should change me+freebsd@igalic.co to it.

Also, I've tried to put a maintainer request on me+freebsd@igalic.co and bugzilla fails with non registered email.
Comment 11 Mike Bristow 2023-01-13 12:38:04 UTC
(In reply to Mina Galić from comment #9)
The build failed without it.  I've managed to break my build box, so I can't check quickly to see if that was an artefact of go 1.19.3 that has disappeared with .5
Comment 12 Mina Galić freebsd_triage 2023-01-13 12:49:38 UTC
Comment on attachment 239440 [details]
Different patch proposed to update net-im/gotosocial to version 0.6.0

approving this patch version
Comment 13 Mina Galić freebsd_triage 2023-01-13 12:51:45 UTC
(In reply to Mina Galić from comment #12)
oh, right, i can't, because I'm not the maintainer, according to Bugzilla.

can i add aliases to my Bugzilla login email?
Comment 14 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-13 13:12:30 UTC
(In reply to Mina Galić from comment #13)
I will update port with "attachment 239440 [details]" and fix maintainer email.
Comment 15 Mina Galić freebsd_triage 2023-01-13 13:17:50 UTC
(In reply to Nuno Teixeira from comment #14)
maybe hold off on that, and I'll change my email in Bugzilla
Comment 16 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-13 13:53:51 UTC
(In reply to Mina Galić from comment #15)

Remember that you have a port registered with maintainer me@igalic.co

You will run into the same problem with that port. Best way to fix it is sync bugzilla and maintainer email.
Comment 17 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-29 20:28:55 UTC
Friendly ping
Comment 18 Mina Galić freebsd_triage 2023-01-29 21:47:02 UTC
(In reply to Nuno Teixeira from comment #17)
thanks for the ping

changed my bugzilla login to freebsd@igalic.co !!
so we can change my maintainership to that as well.
Comment 19 commit-hook freebsd_committer freebsd_triage 2023-01-30 08:40:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fb028a3fb6e34487288d931fb4fad4850100c9a3

commit fb028a3fb6e34487288d931fb4fad4850100c9a3
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2023-01-30 08:37:41 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-01-30 08:39:22 +0000

    */*: Update maintainer e-mail

    PR:             268228

 accessibility/gammy/Makefile  | 2 +-
 net-im/gotosocial/Makefile    | 2 +-
 net/cloud-init-devel/Makefile | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Comment 20 commit-hook freebsd_committer freebsd_triage 2023-01-30 09:45:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9507957f2dd618cb9ab3edf71bdb2335342d9856

commit 9507957f2dd618cb9ab3edf71bdb2335342d9856
Author:     SolarCatcher <solarcatcher@gmx.de>
AuthorDate: 2023-01-30 09:42:50 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-01-30 09:44:22 +0000

    net-im/gotosocial: Update to 0.6.0

    ChangeLog:
    https://github.com/superseriousbusiness/gotosocial/releases/tag/v0.6.0

    PR:             268228

 net-im/gotosocial/Makefile  |  3 +-
 net-im/gotosocial/distinfo  | 10 ++---
 net-im/gotosocial/pkg-plist | 91 ++++++++++++++++++++++-----------------------
 3 files changed, 50 insertions(+), 54 deletions(-)
Comment 21 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-30 09:48:23 UTC
Committed, thanks!