Bug 268294 - security/softether5: fix wrong CMAKE_BOOL_ON
Summary: security/softether5: fix wrong CMAKE_BOOL_ON
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-10 11:14 UTC by Robert Clausecker
Modified: 2022-12-10 23:17 UTC (History)
1 user (show)

See Also:
meta: maintainer-feedback+
meta: merge-quarterly+

Attachments
security/softether5: fix wrong CMAKE_BOOL_ON (1.21 KB, patch)
2022-12-10 11:14 UTC, Robert Clausecker 		fuz: maintainer-approval? (meta)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-12-10 11:14:41 UTC 
Created attachment 238688 [details]
security/softether5: fix wrong CMAKE_BOOL_ON

No macro with this name is checked by USES=cmake.  The correct
one would be CMAKE_ON, but that one is not evaluated again after
bsd.port.pre.mk.  Just directly add -DSKIP_CPU_FEATURES=1 to
CMAKE_ARGS to work around this shortcoming.

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Please MFH if possible.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-12-10 23:10:30 UTC 
Do you approve of the patch?  If yes, please set the maintainer-approval flag on the patch.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-12-10 23:12:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e1e189c2117ca7337a6133cb45523c249b6a7cd3

commit e1e189c2117ca7337a6133cb45523c249b6a7cd3
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-12-10 11:13:17 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2022-12-10 23:09:29 +0000

    security/softether5: fix wrong CMAKE_BOOL_ON

    PR:             268294

    No macro with this name is checked by USES=cmake.  The correct
    one would be CMAKE_ON, but that one is not evaluated again after
    bsd.port.pre.mk.  Just directly add -DSKIP_CPU_FEATURES=1 to
    CMAKE_ARGS to work around this shortcoming.

 security/softether5/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-12-10 23:14:05 UTC 
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7e94a6e01792de3f14b70b2855151fd84064192d

commit 7e94a6e01792de3f14b70b2855151fd84064192d
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-12-10 11:13:17 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2022-12-10 23:12:36 +0000

    security/softether5: fix wrong CMAKE_BOOL_ON

    PR:             268294

    No macro with this name is checked by USES=cmake.  The correct
    one would be CMAKE_ON, but that one is not evaluated again after
    bsd.port.pre.mk.  Just directly add -DSKIP_CPU_FEATURES=1 to
    CMAKE_ARGS to work around this shortcoming.

    (cherry picked from commit e1e189c2117ca7337a6133cb45523c249b6a7cd3)

 security/softether5/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2022-12-10 23:17:53 UTC 
Cmmitted, thanks!