Bug 268313 - databases/kyotocabinet: add prototypes to kclangc.h declarations.
Summary: databases/kyotocabinet: add prototypes to kclangc.h declarations.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2022-12-11 13:55 UTC by Matthias Andree
Modified: 2023-01-30 14:06 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
proposed port fix (2.43 KB, patch)
2022-12-11 13:55 UTC, Matthias Andree
mandree: maintainer-approval? (sunpoet)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2022-12-11 13:55:41 UTC
Created attachment 238707 [details]
proposed port fix

Hi sunpoet, 

please review the attached patch and decide on approval. Thanks in advance.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-12-16 22:53:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8b60e005cdb55fcf5100bd295bb9b8940515f63a

commit 8b60e005cdb55fcf5100bd295bb9b8940515f63a
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2022-12-11 13:51:49 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2022-12-16 22:08:29 +0000

    databases/kyotocabinet: add prototypes to kclangc.h declarations.

    Some function declarations just use () as argument list. This is
    valid C++, but not C, and clang-15 complains with -Wstrict-prototypes:

    /usr/local/include/kclangc.h:261:13: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
    double kcnan();
                ^
                 void
    /usr/local/include/kclangc.h:268:13: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
    double kcinf();
                ^
                 void
    /usr/local/include/kclangc.h:1525:18: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
    KCLIST* kclistnew();
                      ^
                       void

    Add the missing void.

    PR:             268313

 databases/kyotocabinet/Makefile                    |  1 +
 databases/kyotocabinet/files/patch-kclangc.h (new) | 28 ++++++++++++++++++++++
 2 files changed, 29 insertions(+)