Please, see review: D37706 for details.
Created attachment 238888 [details] patch patch
(In reply to Juraj Lutter from comment #1) As I indicated in D37706, the patch looks good. I'm only concerned we've gone from 8.0 to 8.2 with for no apparent reason. The CHANGELOG that comes with the source doesn't say anything. The file VERSION that comes with the source claims: 8.0. It looks like somethings wrong in claiming this version to be 8.2. Thanks. --Chris
The file VERSION from the source reads "8.2". We got from 8.0 to 8.2 simply because there was no version 8.1 released.
(In reply to Chris Hutchinson from comment #2) Please, set maintainer approval on both PR and patch if "LGTM". Thanks.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=140ae6990b6715f2eabdc68db2575aa82f115661 commit 140ae6990b6715f2eabdc68db2575aa82f115661 Author: Juraj Lutter <otis@FreeBSD.org> AuthorDate: 2022-12-14 21:31:41 +0000 Commit: Juraj Lutter <otis@FreeBSD.org> CommitDate: 2022-12-20 12:14:54 +0000 net/rpki-client: Update to 8.2 - Update to 8.2 - Switch from GH to OpenBSD CDN master sites Approved by: Chris Hutchinson <portmaster@BSDforge.com> (maintainer) PR: 268439 Differential Revision: https://reviews.freebsd.org/D37706 net/rpki-client/Makefile | 12 +++--------- net/rpki-client/distinfo | 8 +++----- 2 files changed, 6 insertions(+), 14 deletions(-)
Committed, thanks.
(In reply to Juraj Lutter from comment #3) > The file VERSION from the source reads "8.2". We got from 8.0 to 8.2 simply because there was no version 8.1 released. Sorry. But for some reason. The copy I downloaded from the same links now in the Makefile. Had listed 8.0 in VERSION. I have no explanation as to why/how. But just thought I'd mention it. So you'd know why I kept asking about it. Thanks for everything. --Chris