Created attachment 238965 [details] patch for print/epson-inkjet-printer-escpr2 epson-inkjet-printer-escpr2 has been updated to 1.1.58. New PPD files for the following models have been added. EP-885A series ET-2830 series ET-2840 series L3550 series L3560 series L5590 series L8050 series PX-M887F PX-S730 series PX-S887 WF-C4310 series WF-C5310 series WF-C5390BAM WF-C5390 series WF-C5810 series WF-C5890BAM WF-C5890 series Some of the wording in pkg-descr has been edited to allow it to pass portlint. The build has been successful in the following environments in poudriere. 12.4-STABLE 1204500 amd64
Hello, ====> Running Q/A tests (stage-qa) Warning: Bad symlink '/usr/local/share/cups/model/epson-inkjet-printer-escpr2' pointing to an absolute pathname '/compat/linux/opt/epson-inkjet-printer-escpr2/ppds/Epson' Could you check it? Small cosmetic fix: --- -PLIST_SUB+= ARCH_AMD64="" -PLIST_SUB+= ARCH_I386="@comment " +PLIST_SUB+= ARCH_AMD64="" \ + ARCH_I386="@comment " .elif ${ARCH} == i386 -PLIST_SUB+= ARCH_AMD64="@comment " -PLIST_SUB+= ARCH_I386="" +PLIST_SUB+= ARCH_AMD64="@comment " \ + ARCH_I386="" --- Cheers
(In reply to Nuno Teixeira from comment #1) > Warning: Bad symlink '/usr/local/share/cups/model/epson-inkjet-printer-escpr2' pointing > Could you check it? The path is hard-coded in linux emulation, so an absolute path should be fine. https://cgit.freebsd.org/src/tree/sys/compat/linux/linux_util.c?id=c89209c674f2c867a2a3a4cccd4760311399d7e4#n83 Warning is not an error :) > Small cosmetic fix: If this is something that should be fixed, would it be possible to have it fixed and committed on your side? In that case, it is committed as is. Or should I prepare a new patch that fixes it?
(In reply to Tatsuki Makino from comment #2) Thanks for explanation. I commit the small cosmetic fix. Cheers
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=049e392a739c23e237eaf3f23a7c65768c7c056a commit 049e392a739c23e237eaf3f23a7c65768c7c056a Author: Tatsuki Makino <tatsuki_makino@hotmail.com> AuthorDate: 2022-12-23 22:18:55 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-12-23 22:18:55 +0000 print/epson-inkjet-printer-escpr2: Update to 1.1.58 ChangeLog: New PPD files for the following models have been added. EP-885A series ET-2830 series ET-2840 series L3550 series L3560 series L5590 series L8050 series PX-M887F PX-S730 series PX-S887 WF-C4310 series WF-C5310 series WF-C5390BAM WF-C5390 series WF-C5810 series WF-C5890BAM WF-C5890 series PR: 268507 print/epson-inkjet-printer-escpr2/Makefile | 24 ++++++++++++------------ print/epson-inkjet-printer-escpr2/distinfo | 14 +++++++------- print/epson-inkjet-printer-escpr2/pkg-descr | 5 +++-- print/epson-inkjet-printer-escpr2/pkg-plist | 17 +++++++++++++++++ 4 files changed, 39 insertions(+), 21 deletions(-)
Committed, thanks!
Thank you very much.