Created attachment 238980 [details] Patch for libdeflate * Switch to CMake (upstream) * Backport upstream commit 98174ac5e6fe2a806923bcb6bfa24cdbf32c79d0 * Switch to pkg-plist Compile and runtime tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist, make test) Poudriere testport OK 12.3-RELEASE (amd64) Poudriere testport OK 13.1-RELEASE (i386)
Tested with following users in Poudriere, FreeBSD 12.3-RELEASE (amd64): archivers/advancecomp biology/fastp biology/htslib biology/vt devel/notcurses graphics/tiff
Friendly ping
> cmake:testing pathfix Interesting: pathfix apparently does its thing, looking at the log diff: --- Installing: $wrkdir/stage/usr/local/lib/pkgconfig/libdeflate.pc +-- Installing: $wrkdir/stage/usr/local/libdata/pkgconfig/libdeflate.pc But resulting pkg-plist is correct regardless of USES+=pathfix. > Backport upstream commit 98174ac5e6fe2a806923bcb6bfa24cdbf32c79d0 How exactly is it needed? Looks like it affects futimes(2) detection. What's desired logic here?
Hi, There's a "safeguard" here https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n3538 but I prefer to fix paths so output and logs are consistent. To be honest I backported 98174ac5e6fe2a806923bcb6bfa24cdbf32c79d0 simply because of consistentcy so unit tests reflects on release binaries. Best regards, Daniel
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c8d13ef7f3386389410c492dedb63858bbe7f1cc commit c8d13ef7f3386389410c492dedb63858bbe7f1cc Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2023-01-05 08:21:46 +0000 Commit: Alexey Dokuchaev <danfe@FreeBSD.org> CommitDate: 2023-01-05 08:21:46 +0000 archivers/libdeflate: update the port to version 1.15 - The build system had been switched to CMake, adjust the Makefile accordingly and convert outgrown PLIST_FILES into static pkg-plist - Backport one upstream commit for the sake of consistency, so unit tests reflect on release binaries (it also happens to inadvertently inhibit detection of futimes(2), which is deprecated interface as it does not provide nanosecond accuracy, so it's probably okay) - Do not pass "-O2 -DNDEBUG" on release CFLAGS: -O2 is redundant and NDEBUG is not actually used anywhere in the library source code PR: 268519 archivers/libdeflate/Makefile | 23 +++++++++---------- archivers/libdeflate/distinfo | 8 ++++--- archivers/libdeflate/files/patch-Makefile (gone) | 29 ------------------------ archivers/libdeflate/pkg-plist (new) | 13 +++++++++++ 4 files changed, 29 insertions(+), 44 deletions(-)
Thank you for elaborate patch and your patience.