Bug 268558 - archivers/snappy-java: does not work with Java >=17
Summary: archivers/snappy-java: does not work with Java >=17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Juraj Lutter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-25 16:03 UTC by wcarson.bugzilla
Modified: 2023-10-18 13:55 UTC (History)
4 users (show)

See Also:
language.devel: maintainer-feedback+


Attachments
Update to 1.1.10.5 (13.68 KB, patch)
2023-10-16 06:39 UTC, Juraj Lutter
otis: maintainer-approval?
Details | Diff
Removed duplicate in distinfo (13.46 KB, patch)
2023-10-18 05:39 UTC, Angelo Polo
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description wcarson.bugzilla 2022-12-25 16:03:29 UTC
Overview:

    Attempting to build archivers/java-snappy with JAVA_VERSION=17+ results in error:

        2022-12-25 15:43:00,525 main ERROR Could not determine local host name java.net.UnknownHostException: FreeBSD:13:aarch64-HEAD-job-01: FreeBSD:13:aarch64-HEAD-job-01: Name does not resolve
        Project loading failed: (r)etry, (q)uit, (l)ast, or (i)gnore? [0m[[0m[31merror[0m] [0m[0mjava.io.IOError: java.lang.RuntimeException: /packages cannot be represented as URI[0m


Steps to Reproduce:

    1) Edit archivers/snappy-java/Makefile and add JAVA_VERSION=17

    2) make package

    3) Observe failure

Actual Results:

    The build fails with the above error(s).

Expected Results: 

    The package should successfully build. 

Build Date & Hardware: 

    Built on a RockPro64 (aarch64) running 13.1-RELEASE-p5 with ports commit 7dda4a77b8bbe5daab22301a0e1e992a195bd139 dated Wed Dec 21 21:16:58 2022 +0000.

Additional Information: 

    Adding "JAVA_VERSION=8 11" to the Makefile resolves the issue.
Comment 1 Ronald Klop freebsd_committer freebsd_triage 2023-08-22 10:04:52 UTC
This version adds a build test for java 17. So it might work better. Untested.
https://github.com/xerial/snappy-java/releases/tag/v1.1.9.0
Comment 2 Juraj Lutter freebsd_committer freebsd_triage 2023-09-26 21:17:55 UTC
There is even newer version now (1.1.10.4)

Maintainer should cooperate with pi@ who is hosting the maven repository.
Comment 3 Angelo Polo 2023-09-27 06:22:57 UTC
(In reply to Juraj Lutter from comment #2)

I'm getting on it! Thanks.
Comment 4 Juraj Lutter freebsd_committer freebsd_triage 2023-09-27 16:16:08 UTC
(In reply to Angelo Polo from comment #3)
Thanks. Please keep us posted.
Comment 5 Angelo Polo 2023-10-07 12:12:21 UTC
There's a snag with checking out git submodules, or rather the fact that USE_GITHUB doesn't check them out. I've opened a forum thread to seek some help on this:
https://forums.freebsd.org/threads/configure-use_github-to-download-submodules.90531/
Comment 6 Juraj Lutter freebsd_committer freebsd_triage 2023-10-08 18:21:35 UTC
See review D42128

It needs a very little bit of work (like, to generate properly versioned resulting .jar file), but it builds.

Now I'm testing it with newer net-mgmt/unifi7 (that needs OpenJDK17).
Comment 7 Angelo Polo 2023-10-09 03:31:15 UTC
(In reply to Juraj Lutter from comment #6)

Can you say specifically what you did to deal with this problem:
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  ::          UNRESOLVED DEPENDENCIES         ::
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  :: org.xerial.sbt#sbt-sonatype;3.9.21: not found
[warn]  :: com.github.sbt#sbt-pgp;2.2.1: not found
[warn]  :: com.typesafe.sbt#sbt-osgi;0.9.6: not found
[warn]  :: org.scalameta#sbt-scalafmt;2.5.2: not found
[warn]  :: com.github.sbt#sbt-dynver;5.0.1: not found
[warn]  :: org.scala-lang#scala-library;2.12.18: not found
[warn]  :: org.scala-lang#scala-compiler;2.12.18: not found
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
Comment 8 Juraj Lutter freebsd_committer freebsd_triage 2023-10-09 13:46:45 UTC
I've made a .tar.gz with:

- repository
- sbt_boot
- sbt_global

And made it accessible as http://distcache.freebsd.org/local-distfiles/otis/snappy-java-repository-1.1.10.5.tar.gz
Comment 9 Juraj Lutter freebsd_committer freebsd_triage 2023-10-16 06:39:42 UTC
Created attachment 245667 [details]
Update to 1.1.10.5
Comment 10 Angelo Polo 2023-10-18 05:39:52 UTC
Created attachment 245705 [details]
Removed duplicate in distinfo
Comment 11 commit-hook freebsd_committer freebsd_triage 2023-10-18 13:49:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ec69541aaabafb36d0dcebf3427611357eced022

commit ec69541aaabafb36d0dcebf3427611357eced022
Author:     Juraj Lutter <otis@FreeBSD.org>
AuthorDate: 2023-10-18 13:45:54 +0000
Commit:     Juraj Lutter <otis@FreeBSD.org>
CommitDate: 2023-10-18 13:47:41 +0000

    archivers/snappy-java: Update to 1.1.10.5

    PR:             268558
    Reported by:    wcarson.bugzilla@disillusion.net
    Co-authored-by: Angelo Polo <language.devel@gmail.com>

 archivers/snappy-java/Makefile                     | 72 ++++++++++++----------
 archivers/snappy-java/distinfo                     | 22 ++++---
 archivers/snappy-java/files/patch-Makefile         | 46 +++++---------
 archivers/snappy-java/files/patch-Makefile.common  | 31 +++++++---
 .../files/patch-project_plugins.sbt (gone)         |  8 ---
 5 files changed, 93 insertions(+), 86 deletions(-)
Comment 12 Juraj Lutter freebsd_committer freebsd_triage 2023-10-18 13:55:06 UTC
Committed, thanks.