Bug 268750 - www/firefox: draft patch to fix build on armv7
Summary: www/firefox: draft patch to fix build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-04 11:54 UTC by Robert Clausecker
Modified: 2025-03-09 23:17 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (gecko)

Attachments
www/firefox: draft patch to fix build on armv7 (1.97 KB, patch)
2023-01-04 11:54 UTC, Robert Clausecker 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2023-01-04 11:54:45 UTC 
Created attachment 239258 [details]
www/firefox: draft patch to fix build on armv7

The attached patch fixes a build issue on armv7.  Unfortunately the build then fails later with an address space exhaustion in the compiler when compiling the rust "style" package.

Tested unsuccessfully on armv7 FreeBSD 13.1.
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2023-04-23 08:49:13 UTC 
Thanks, 

(In reply to Robert Clausecker from comment #0)

Any better on 13.2-RELEASE?
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2023-04-23 14:52:48 UTC 
An OS update is unlikely to fix this kind of problem, but alas I haven't updated my Poudriere jails yet.
Comment 3 commit-hook freebsd_committer freebsd_triage 2025-02-27 01:38:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1dcbab6267403045a02ba0175f11a4a1adec5d93

commit 1dcbab6267403045a02ba0175f11a4a1adec5d93
Author:     Martin Filla <freebsd@sysctl.cz>
AuthorDate: 2025-02-27 00:42:05 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-02-27 01:37:05 +0000

    www/waterfox: Add experimental patch for fix build on armv7

    The author of the patch is fuz.

    PR:     285010 268750
    MFH:    2025Q1

 .../patch-gfx_skia_skia_src_core_SkCpu.cpp (new)   | 29 ++++++++++++++++++++++
 1 file changed, 29 insertions(+)
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-02-27 01:38:56 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5f078edb2200c9998cb5cdf3782952243114c29e

commit 5f078edb2200c9998cb5cdf3782952243114c29e
Author:     Martin Filla <freebsd@sysctl.cz>
AuthorDate: 2025-02-27 00:35:20 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-02-27 01:37:05 +0000

    www/tor-browser: Add experimental patch for fix build on armv7

    The author of the patch is fuz.

    PR:     285009 268750
    MFH:    2025Q1

 .../patch-gfx_skia_skia_src_core_SkCpu.cpp (new)   | 29 ++++++++++++++++++++++
 1 file changed, 29 insertions(+)
Comment 5 commit-hook freebsd_committer freebsd_triage 2025-02-27 01:43:59 UTC 
A commit in branch 2025Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f28f4486741f4ab657df2a9eca307ff4443da383

commit f28f4486741f4ab657df2a9eca307ff4443da383
Author:     Martin Filla <freebsd@sysctl.cz>
AuthorDate: 2025-02-27 00:35:20 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-02-27 01:42:44 +0000

    www/tor-browser: Add experimental patch for fix build on armv7

    The author of the patch is fuz.

    PR:     285009 268750
    MFH:    2025Q1
    (cherry picked from commit 5f078edb2200c9998cb5cdf3782952243114c29e)

 .../patch-gfx_skia_skia_src_core_SkCpu.cpp (new)   | 29 ++++++++++++++++++++++
 1 file changed, 29 insertions(+)
Comment 6 commit-hook freebsd_committer freebsd_triage 2025-02-27 01:44:01 UTC 
A commit in branch 2025Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0eff4ac2c1d628d41dafcf61b4558dd8d174f65d

commit 0eff4ac2c1d628d41dafcf61b4558dd8d174f65d
Author:     Martin Filla <freebsd@sysctl.cz>
AuthorDate: 2025-02-27 00:42:05 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-02-27 01:42:59 +0000

    www/waterfox: Add experimental patch for fix build on armv7

    The author of the patch is fuz.

    PR:     285010 268750
    MFH:    2025Q1
    (cherry picked from commit 1dcbab6267403045a02ba0175f11a4a1adec5d93)

 .../patch-gfx_skia_skia_src_core_SkCpu.cpp (new)   | 29 ++++++++++++++++++++++
 1 file changed, 29 insertions(+)
Comment 7 Mark Linimon freebsd_committer freebsd_triage 2025-03-09 21:59:26 UTC 
^Triage: the patch refers to a file files/patch-gfx_skia_skia_src_core_SkCpu.cpp
which no longer exists.  Is there anything else that needs to be done with
this PR?
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2025-03-09 22:04:05 UTC 
The patch has been committed, I have been waiting for the committer to close it.  I guess I can do so now.
Comment 9 Vladimir Druzenko freebsd_committer freebsd_triage 2025-03-09 23:17:02 UTC 
patch-gfx_skia_skia_src_core_SkCpu.cpp committed to librewolf, tor-browser and waterfox, but not to firefox*.