Bug 268761 - net/krfb: enable PipeWire support (for Plasma/Wayland)
Summary: net/krfb: enable PipeWire support (for Plasma/Wayland)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL: https://reviews.freebsd.org/D39976
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-05 05:37 UTC by Jan Beich
Modified: 2023-05-11 10:04 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+

Attachments
v1 (apply via "git am") (1.84 KB, patch)
2023-01-05 05:37 UTC, Jan Beich 		no flags Details | Diff
Make pipewire optional (1.77 KB, patch)
2023-04-21 16:59 UTC, Vladimir Druzenko 		no flags Details | Diff
Make pipewire optional (1.90 KB, patch)
2023-04-21 17:50 UTC, Vladimir Druzenko 		vvd: maintainer-approval?
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2023-01-05 05:37:40 UTC 
Created attachment 239271 [details]
v1 (apply via "git am")

"poudriere bulk -t" is OK on 12.3 amd64+i386, 12.4 amd64, 13.1 amd64+i386, 14.0 amd64.

I didn't test Plasma (plasma5-xdg-desktop-portal-kde) or GNOME (xdg-desktop-portal-gnome) but Sway (recipe a la bug 268726) failed due to https://github.com/emersion/xdg-desktop-portal-wlr/issues/2

$ sway
[...]
$ dbus-monitor &
$ krfb
[...]
method call time=12345.418 sender=:1.92 -> destination=org.freedesktop.portal.Desktop serial=8 path=/org/freedesktop/portal/desktop; interface=org.freedesktop.DBus.Properties; member=Get
   string "org.freedesktop.portal.ScreenCast"
   string "version"
method return time=12345.560 sender=:1.79 -> destination=:1.92 serial=71 reply_serial=8
   variant       uint32 4
method call time=12345.738 sender=:1.92 -> destination=org.freedesktop.portal.Desktop serial=9 path=/org/freedesktop/portal/desktop; interface=org.freedesktop.portal.RemoteDesktop; member=CreateSession
   array [
      dict entry(
         string "handle_token"
         variant             string "krfb3150185179"
      )
      dict entry(
         string "session_handle_token"
         variant             string "krfb4065415786"
      )
   ]
error time=12345.835 sender=:1.79 -> destination=:1.92 error_name=org.freedesktop.DBus.Error.UnknownMethod reply_serial=9
   string "No such interface “org.freedesktop.portal.RemoteDesktop” on object at path /org/freedesktop/portal/desktop"
Couldn't initialize XDP-KDE screencast session
[..]
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2023-04-15 16:40:25 UTC 
Moin moin 

Sounds like a good idea.
Please go ahead.


mfg Tobias
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2023-04-21 16:59:36 UTC 
Created attachment 241633 [details]
Make pipewire optional

Tested on 13.2 amd64.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2023-04-21 17:50:47 UTC 
Created attachment 241635 [details]
Make pipewire optional

Formatting.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-05-11 09:58:56 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3e6fe6466f5021164ff3a0cdaea982bdf9b2b106

commit 3e6fe6466f5021164ff3a0cdaea982bdf9b2b106
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2023-05-11 09:54:28 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2023-05-11 09:57:22 +0000

    net/krfb: make pipewire optional

    Keep it on by default.

    PR:                     268761
    Approved by:            arrowd (mentor, kde@)
    Differential Revision:  https://reviews.freebsd.org/D39976

 net/krfb/Makefile  | 18 +++++++++++-------
 net/krfb/pkg-plist |  4 ++--
 2 files changed, 13 insertions(+), 9 deletions(-)
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2023-05-11 10:04:09 UTC 
I think we can close this: support of the PipeWire is enabled for the net/krfb and ON by default.