Bug 268774 - lang/itcl: fails to build
Summary: lang/itcl: fails to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Pietro Cerutti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-05 19:16 UTC by Dan Langille
Modified: 2023-01-16 10:04 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (erik)

Attachments
update to 3.4.4 (1.31 KB, patch)
2023-01-13 18:34 UTC, Dan Langille 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Langille freebsd_committer freebsd_triage 2023-01-05 19:16:49 UTC 
From https://portsfallout.com/fallout?port=lang%2Fitcl%24 this port is failing to build on multiple platforms.  I'm having trouble with FreeBSD 13.1 on amd64 using the 2023Q1 branch and on head.

From https://pkg-status.freebsd.org/beefy8/data/main-armv6-default/pb9763bb5d470_sb069d3e019/logs/itcl-3.4.1_1,1.log

 /nxb-bin/usr/bin/cc -DPACKAGE_NAME=\"itcl\" -DPACKAGE_TARNAME=\"itcl\" -DPACKAGE_VERSION=\"3.4\" -DPACKAGE_STRING=\"itcl\ 3.4\" -DPACKAGE_BUGREPORT=\"\" -DBUILD_itcl= -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DNO_VALUES_H=1 -DHAVE_LIMITS_H=1 -DHAVE_SYS_PARAM_H=1 -DTCL_THREADS=1 -DMODULE_SCOPE=extern\ __attribute__\(\(__visibility__\(\"hidden\"\)\)\) -DTCL_WIDE_INT_TYPE=long\ long -DUSE_TCL_STUBS=1    -DITCL_LIBRARY=\"/usr/local/lib/itcl3.4\" -I"./generic" -I"/usr/local/include/tcl8.6/generic" -I"/usr/local/include/tcl8.6/unix"    -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -pipe  -O2 -Wall -fPIC -c `echo ./generic/itcl_methods.c` -o itcl_methods.o
./generic/itcl_methods.c:1148:48: error: invalid application of 'sizeof' to an incomplete type 'char[]'
        (unsigned)(sizeof(CompiledLocal)-sizeof(localPtr->name) + nameLen+1)
                                               ^~~~~~~~~~~~~~~~
/usr/local/include/tcl8.6/generic/tcl.h:2462:36: note: expanded from macro 'ckalloc'
    ((void *) Tcl_Alloc((unsigned)(x)))
                                   ^
1 error generated.
*** Error code 1
Comment 1 Dan Langille freebsd_committer freebsd_triage 2023-01-13 18:34:23 UTC 
Created attachment 239454 [details]
update to 3.4.4

I have attached a patch for 3.4.4 but really need someone to test it. I am unsure of the pkg-plist changess.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-01-16 10:03:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d03240afda91c970ace4b2fb5d6c86724e8a0b58

commit d03240afda91c970ace4b2fb5d6c86724e8a0b58
Author:     Pietro Cerutti <gahr@FreeBSD.org>
AuthorDate: 2023-01-16 09:59:00 +0000
Commit:     Pietro Cerutti <gahr@FreeBSD.org>
CommitDate: 2023-01-16 10:02:10 +0000

    lang/itcl, x11-toolkits/itk: unbreak and update

    PR:             268774

 lang/itcl/Makefile                               | 18 ++++++++----------
 lang/itcl/distinfo                               |  5 +++--
 lang/itcl/pkg-plist                              |  5 ++---
 x11-toolkits/itk/Makefile                        | 13 +++++++------
 x11-toolkits/itk/distinfo                        |  5 +++--
 x11-toolkits/itk/files/patch-nointerptest (gone) | 21 ---------------------
 6 files changed, 23 insertions(+), 44 deletions(-)
Comment 3 Pietro Cerutti freebsd_committer freebsd_triage 2023-01-16 10:04:34 UTC 
Thanks! I pushed an update to Itcl and Itk, and checked that some dependencies build fine.