Bug 268842 - security/kc: update to 2.5.1
Summary: security/kc: update to 2.5.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-09 15:34 UTC by Daniel
Modified: 2023-01-13 12:31 UTC (History)
1 user (show)

See Also:

Attachments
ports package shar (3.14 KB, text/plain)
2023-01-09 15:34 UTC, Daniel 		leva: maintainer-approval+
Details
patch to kc24 (3.48 KB, patch)
2023-01-10 10:02 UTC, Daniel 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel 2023-01-09 15:34:08 UTC 
Created attachment 239363 [details]
ports package shar

Conflicts with the previous version with package name `kc24'. IIRC it had to coexist with an older version at that time (<2.4) so people can export/import their databases safely.

Package names remains `kc'.
Comment 1 Daniel 2023-01-09 15:36:31 UTC 
Come to think of it, I'm not sure if `kc24' port should be dropped and replaced by this. I'm not that familiar with this process.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-09 16:01:32 UTC 
I don't understand. This is a new port right? Have we had kc24 and kc at the same time in the past?
Comment 3 Daniel 2023-01-09 16:19:26 UTC 
It's an update, as the summary suggests.
Yes, in the past, there were two ports because of the mentioned db change.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-10 07:29:58 UTC 
(In reply to Daniel from comment #3)
Then I think we should apply these changes to security/kc24 and then rename the port to security/kc, and add a note to MOVED.
Comment 5 Daniel 2023-01-10 10:01:45 UTC 
(In reply to Fernando Apesteguía from comment #4)
Cool, this makes sense, thank you!

I'm attaching a diff to kc24. Not sure how to handle the rename, though.
Comment 6 Daniel 2023-01-10 10:02:14 UTC 
Created attachment 239375 [details]
patch to kc24
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-11 07:26:34 UTC 
(In reply to Daniel from comment #6)
I'll do it before committing, thanks!
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-13 12:31:03 UTC 
Committed,

Thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-01-13 12:31:17 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d4fef53722a4be4afcfd38edea06e73daef97a3e

commit d4fef53722a4be4afcfd38edea06e73daef97a3e
Author:     Daniel <leva@ecentrum.hu>
AuthorDate: 2023-01-13 12:25:06 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-01-13 12:26:32 +0000

    security/kc: update to 2.5.1

    kc24 was a transient port to easy the migration of the database. Later on, the
    original kc port was obsoleted. Rename kc24 to kc to match upstream again and
    update to latest version.

    PR:             268842
    Reported by:    leva@ecentrum.hu (maintainer)

 MOVED                            |  2 +-
 security/Makefile                |  2 +-
 security/{kc24 => kc}/Makefile   | 14 ++++++------
 security/kc/distinfo (new)       |  3 +++
 security/{kc24 => kc}/pkg-descr  |  0
 security/kc/pkg-message (new)    | 36 +++++++++++++++++++++++++++++++
 security/kc24/distinfo (gone)    |  3 ---
 security/kc24/pkg-message (gone) | 46 ----------------------------------------
 8 files changed, 49 insertions(+), 57 deletions(-)