Bug 268853 - multimedia/libopenshot: Adding resvg option
Summary: multimedia/libopenshot: Adding resvg option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-10 08:33 UTC by Tatsuki Makino
Modified: 2023-01-11 09:32 UTC (History)
2 users (show)

See Also:


Attachments
patch for multimedia/libopenshot (1.80 KB, patch)
2023-01-10 08:33 UTC, Tatsuki Makino
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tatsuki Makino 2023-01-10 08:33:13 UTC
Created attachment 239373 [details]
patch for multimedia/libopenshot

Since resvg-capi port has been added by yuri, the option to use it is added to this.
There is no problem with check-orphans, only a change in the arguments at build time.
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-10 15:47:20 UTC
(In reply to Tatsuki Makino from comment #0)

====> Running Q/A tests (stage-qa)
Error: /usr/local/lib/libopenshot.so.0.3.0 is linked to /usr/local/lib/libresvg.so which does not have a SONAME.  graphics/resvg-capi needs to be fixed.

Any clues?
Comment 2 Tatsuki Makino 2023-01-10 23:37:40 UTC
(In reply to Nuno Teixeira from comment #1)

The option is off by default :)

And that seems to be the problem with Rust-Cargo itself.
https://github.com/rust-lang/cargo/issues/5045
I sent an email to yuri regarding a workaround.

I think it is something that there is no particular problem with committing as it is.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2023-01-10 23:56:14 UTC
It's Rust who has to fix the SONAME problem.
I also agree that this can be committed as it is now.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-01-11 08:32:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bd6e5ab3ccf890cf333093d002f7313da855e024

commit bd6e5ab3ccf890cf333093d002f7313da855e024
Author:     Tatsuki Makino <tatsuki_makino@hotmail.com>
AuthorDate: 2023-01-11 08:24:48 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-01-11 08:31:23 +0000

    multimedia/libopenshot: Add resvg option

    - Add resvg (graphics/resvg-capi) build option

    PR:             268853

 multimedia/libopenshot/Makefile | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-11 09:32:00 UTC
Committed, thanks!