Bug 268870 - net/frr8: gawk build dependency unneeded
Summary: net/frr8: gawk build dependency unneeded
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Cochard
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2023-01-10 21:55 UTC by Eugene Grosbein
Modified: 2023-01-10 23:53 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (olivier)
eugen: maintainer-feedback? (olivier)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Grosbein freebsd_committer freebsd_triage 2023-01-10 21:55:29 UTC 
Hi!

The port net/frr8 does not really need
BUILD_DEPENDS= gawk:lang/gawk

Please replace this with
CONFIGURE_ENV+= GAWK=${AWK}

It builds just fine then because it does not use any of GNU awk extensions.
Comment 1 Eugene Grosbein freebsd_committer freebsd_triage 2023-01-10 22:04:16 UTC 
In fact, the line
CONFIGURE_ENV+= GAWK=${AWK}

is not needed, too. Just remove gawk:lang/gawk from BUILD_DEPENDS. It uses plain awk command just fine.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-01-10 23:53:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=47bc98dd353128d172dd01055beb9f7d29292154

commit 47bc98dd353128d172dd01055beb9f7d29292154
Author:     Olivier Cochard <olivier@FreeBSD.org>
AuthorDate: 2023-01-10 23:51:35 +0000
Commit:     Olivier Cochard <olivier@FreeBSD.org>
CommitDate: 2023-01-10 23:53:07 +0000

    net/frr8: Remove useless build dependency

    PR:             268870
    Reported by:    eugen

 net/frr8/Makefile | 1 -
 1 file changed, 1 deletion(-)
Comment 3 Olivier Cochard freebsd_committer freebsd_triage 2023-01-10 23:53:56 UTC 
Thanks!