Created attachment 239437 [details] security/strongswan: Update to 5.9.9 Note that the submitted patch already includes the suggestion from bug #262743. Reference: https://docs.strongswan.org/docs/5.9/os/freebsd.html#_building_strongswan Changelog: https://github.com/strongswan/strongswan/releases/tag/5.9.9
Created attachment 239441 [details] printf-hooks is already set Just bump the version, there is no need to add any option.
Patch is good. can be applied
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=942865477682b3d274c73d78e6a5e9b5591268df commit 942865477682b3d274c73d78e6a5e9b5591268df Author: Jose Luis Duran <jlduran@gmail.com> AuthorDate: 2023-01-13 09:31:24 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-01-14 17:13:48 +0000 security/strongswan: Update to 5.9.9 ChangeLog: https://github.com/strongswan/strongswan/releases/tag/5.9.9 PR: 268918 262743 Reported by: jlduran@gmail.com Approved by: strongswan@Nanoteq.com (maintainer) security/strongswan/Makefile | 6 +++--- security/strongswan/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
Thank you! I see the commit was done with the old patch. It had an extra CONFIGURE_ARGS (--with-printf-hooks=builtin), as recommended in the strongSwan documentation, but we already had it as a default option (BUILTIN). I overlooked initially this fact, later clarified by bug #262743, comment #13.
(In reply to Jose Luis Duran from comment #5) Damn! I was 100% sure I reapplied the new patch. Sorry for that. Since the option does not hurt, I would leave it like this and remove in the next version update if you agree. The other option is removing --with-printf-hooks=builtin and bumping PORTREVISION.
Created attachment 239474 [details] security/strongswan: Remove --with-lib-prefix from CONFIGURE_ARGS (In reply to Fernando Apesteguía from comment #6) No problem! I thought it would be OK to leave as is, however, someone may have any of the other OPTIONS_SINGLE_PRINTF_HOOKS options set (LIBC or VSTR) and I am not sure if it will interfere. Just to err on the side of caution, I've submitted a new patch. The next release is scheduled for April 3: https://github.com/strongswan/strongswan/milestone/8 Thank you!
(In reply to Jose Luis Duran from comment #7) Agreed. Committed. Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a06d57733894d0d68b45f5a7326aca568e4e80b0 commit a06d57733894d0d68b45f5a7326aca568e4e80b0 Author: Jose Luis Duran <jlduran@gmail.com> AuthorDate: 2023-01-15 12:01:39 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-01-15 18:14:17 +0000 security/strongswan: Remove --with-lib-prefix Remove flag already in the default option. PR: 268918 Reported by: jlduran@gmail.com Approved by: strongswan@Nanoteq.com (maintainer, implicit in PR) security/strongswan/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)