Created attachment 239487 [details] poudriere testport log As discussed in bug#265217 there is small patch for nut (libups) dependency. By the way I also add actual varnish depndency (6.x inteead of 4.x). Patch was tested with poudriere, so log is also attached.
Created attachment 239488 [details] collectd5 update patch And I'm attaching patch
Note that your testlog has tested with NUTUPS off. So you haven't actually checked anything related to this bug fix. Did you also test with opotion NUTUPS turned on? You can use poudriere testport -c to set options before a test run.
(In reply to Robert Clausecker from comment #2) Well, it is possible that I messed testport log :-))) But it seems it was not so bad :-))) Meanwhile there was change with USE_OPENLDAP => USES= ldap, so I've modified Makefile to cover this change. New version of patch and new version testport logfile is attached
Created attachment 240644 [details] collectd5 update patch New version of patch
Created attachment 240645 [details] poudriere testport log poudriere testport log is bigger than limit, so you can download it from my cloud
Thank you for the update. The log you sent indicatess that you have one error and one likely error: [00:01:09] ====> Running Q/A tests (stage-qa) [00:01:10] Error: /usr/local/lib/collectd/write_mongodb.so is linked to /usr/local/lib/libbson-1.0.so.0 from devel/libbson but it is not declared as a dependency [00:01:10] Warning: you need LIB_DEPENDS+=libbson-1.0.so:devel/libbson [00:01:10] Warning: www/p5-CGI was in Perl CORE. Check with `corelist CGI 0` and `corelist -a CGI` if it should be conditionally added depending on PERL_LEVEL Please check and adjust the patch. For the future, please xz compress logs if they get too large. External links may go down, Bugzilla is forever (or at least who cares about this bug report once it goes down?)
OK, so I am a little confused. I've made such checking (1): .if ${PERL_LEVEL} >= 500809 CGI_RUN_DEPENDS+= p5-CGI>=0:www/p5-CGI .endif then in logfile there is: [00:01:00] ====> Running Q/A tests (stage-qa) [00:01:01] Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions. OK, so I've changed Makefile to (2): .if ${PERL_LEVEL} >= 500809 CGI_RUN_DEPENDS+= p5-Module-CoreList>=0:devel/p5-Module-CoreList \ p5-CGI>=0:www/p5-CGI .endif then in logfile there is: [00:00:59] ====> Running Q/A tests (stage-qa) [00:01:00] Warning: www/p5-CGI was in Perl CORE. Check with `corelist CGI 0` and `corelist -a CGI` if it should be conditionally added depending on PERL_LEVEL [00:01:01] Warning: devel/p5-Module-CoreList is present in Perl CORE. Check with `corelist Module::CoreList 0` and `corelist -a Module::CoreList` if the dependency is really needed or if it should be conditionally added depending on PERL_LEVEL So which checking I should use? (1) or (2) ? And I'm not sure if checkinng PERL_LEVEL is correct. According to corelist CGI: Data for 2021-01-23 CGI was first released with perl 5.004, deprecated (will be CPAN-only) in v5.19.7 and removed from v5.21.0 So how to check PERL_LEVEL correctly for p5-CGI?
(In reply to Krzysztof from comment #8) I'm sorry, I really don't know the answer to this question. Perhaps you could ask perl@freebsd.org?
Maybe warning about p5-CGI is obsolete? I've found such (old) commit: https://reviews.freebsd.org/rP442419
It is possible. I'll leave it up to you to make a decision.
Created attachment 240671 [details] collectd5 update patch OK, so after some tests and polishing I think that's final version of patch :-)
Created attachment 240672 [details] poudriere testport log And compressed logfile from poudriere
(In reply to Robert Clausecker from comment #11) Can you commit changes? It seems that's implemented correctly now.
Sorry, I forgot about it for the last batch.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=910e52c9d15669b8caf7101011e86786e3b25f54 commit 910e52c9d15669b8caf7101011e86786e3b25f54 Author: Krzysztof <ports@bsdserwis.com> AuthorDate: 2023-03-14 09:35:49 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-03-17 09:02:16 +0000 net-mgmt/collectd5: update varnish dependency, modify nut dependency As discussed in PR 265217 there is small patch for the nut (libups) dependency. I also add the actual varnish depndency (6 instead of 4). PR: 268972, 265217 net-mgmt/collectd5/Makefile | 42 ++++------- net-mgmt/collectd5/files/patch-Makefile.am | 6 +- net-mgmt/collectd5/files/patch-configure.ac | 104 +++++++++++++++++++++++++- net-mgmt/collectd5/files/patch-version-gen.sh | 6 +- 4 files changed, 122 insertions(+), 36 deletions(-)
Thank you for your contribution.