Bug 269047 - [NEW PORT] devel/py-gitlab-webhook-handler
Summary: [NEW PORT] devel/py-gitlab-webhook-handler
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL: https://github.com/ahebrank/gitlab-we...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-19 09:00 UTC by Michael Osipov
Modified: 2023-03-28 09:39 UTC (History)
3 users (show)

See Also:

Attachments
Git-formatted patch (1.82 KB, patch)
2023-01-19 09:03 UTC, Michael Osipov 		no flags Details | Diff
Git-formatted patch (2.26 KB, patch)
2023-03-24 10:17 UTC, Michael Osipov 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Osipov 2023-01-19 09:00:38 UTC 
Attached is a patched for a very nice GitLab webhook receiver in Python. Tested in and out with Poudriere 3.7 to 3.11, a QA bastille jail and the actual code now for years in production. Added all required bits upstream to make it port/FreeBSD friendly.
Comment 1 Michael Osipov 2023-01-19 09:03:16 UTC 
Created attachment 239583 [details]
Git-formatted patch
Comment 2 Michael Osipov 2023-03-21 09:18:07 UTC 
Daniel, would you mind to look at this one as well?
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2023-03-23 20:29:25 UTC 
+Define LICENSE_FILE

Is this port compliant with pep517?

Cheers
Comment 4 Michael Osipov 2023-03-24 08:30:02 UTC 
(In reply to Nuno Teixeira from comment #3)

Changing port regarding license file..and running poudriere again

Regarding PEP 517: When I started to make the projec t(port) pip-compatible I didn't focus on the pyproject.toml file, yes this is necessary in the future, but as far as I understand Bug 268283, the TOML style is not yet (fully) supported by the ports system which makes testing for me hard. The handler is super simple, no brain magic. I'd try to address that issue when the support is there to have a full end to end test.
Comment 5 Michael Osipov 2023-03-24 10:17:53 UTC 
Created attachment 241084 [details]
Git-formatted patch

Updated patch with LICENSE_FILE
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-03-27 19:34:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=866380c886c03989de1650b5f3ef028d7f26f1d0

commit 866380c886c03989de1650b5f3ef028d7f26f1d0
Author:     Michael Osipov <michael.osipov@siemens.com>
AuthorDate: 2023-03-27 19:24:25 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-03-27 19:31:42 +0000

    devel/py-gitlab-webhook-handler: New port: Webhook Handler for GitLab

     - Submitter becomes maintainer

    Webhook Handler for GitLab written in Python with Flask deployed as WSGI
    application.

    WWW:            https://github.com/ahebrank/gitlab-webhook-handler
    PR:             269047

 devel/Makefile                                  |  1 +
 devel/py-gitlab-webhook-handler/Makefile (new)  | 29 +++++++++++++++++++++++++
 devel/py-gitlab-webhook-handler/distinfo (new)  |  3 +++
 devel/py-gitlab-webhook-handler/pkg-descr (new) |  2 ++
 4 files changed, 35 insertions(+)
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2023-03-27 19:34:37 UTC 
Committed, thanks!
Comment 8 Michael Osipov 2023-03-28 09:39:56 UTC 
(In reply to Nuno Teixeira from comment #7)

Perfect, thank you very much. It was quite a lot of work to make it sound and for the ports system as well.