Created attachment 239713 [details] Add xfce flavor
Comment on attachment 239713 [details] Add xfce flavor Looks good to me.
^Triage: reporter is committer, assign accordingly.
LGTM too, please push.
(In reply to Gleb Popov from comment #3) Not worth the anxiety spike to me. Unassigning this. I've done what I could. If it doesn't happen, so be it.
====> Running Q/A tests (stage-qa) Warning: you may not need USES=desktop-file-utils ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: lib/xfce4/panel/plugins/libworkrave-plugin.a Error: Orphaned: lib/xfce4/panel/plugins/libworkrave-plugin.so Error: Orphaned: share/xfce4/panel/plugins/workrave-xfce-applet.desktop ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found.
(In reply to Gleb Popov from comment #5) USES=desktop-file-utils is there because portlint said to (and the PHB confirmed). I'll look at the rest. (I may have forgotten the DEVELOPER= magic incantation in that VM.) Thanks.
Created attachment 239772 [details] Add xfce flavor, this time with correct pkg-plist. ====> Compressing man pages (compress-man) ====> Running Q/A tests (stage-qa) Warning: you may not need USES=desktop-file-utils ===> Installing for workrave-xfce-1.10.50 ===> Checking if workrave-xfce is already installed ===> Switching to root credentials for 'install' target Password: ===> Registering installation for workrave-xfce-1.10.50 Installing workrave-xfce-1.10.50... Generating GTK icon cache for /usr/local/share/icons/hicolor Building cache database of MIME types ===> Returning to user credentials pauamma@FreeBSD-workrave-xfce-flavor:~/ports/x11/workrave % make FLAVOR=xfce check-plist ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist)
Comment on attachment 239772 [details] Add xfce flavor, this time with correct pkg-plist. Looks good to me.
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ab65e95cc8fd0ba5d1ebbe1b5b7e7fd905ec683e commit ab65e95cc8fd0ba5d1ebbe1b5b7e7fd905ec683e Author: Pau Amma <pauamma@FreeBSD.org> AuthorDate: 2023-01-29 17:36:41 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-01-29 18:21:42 +0000 x11/workrave: add flavor for XFCE support Deliberately not bumping PORTREVISION. PR: 269160 Reported by: pauamma@FreeBSD.org Reviewed by: cyberbotx@cyberbotx.com (maintainer) x11/workrave/Makefile | 28 +++++++++++++++++++++++----- x11/workrave/pkg-descr.xfce (new) | 6 ++++++ 2 files changed, 29 insertions(+), 5 deletions(-)