Bug 269337 - dns/unbound: fails to patch phase with AAAA option ON
Summary: dns/unbound: fails to patch phase with AAAA option ON
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-05 14:48 UTC by void
Modified: 2023-02-07 16:04 UTC (History)
2 users (show)

See Also:
jaap: maintainer-feedback+
fernape: merge-quarterly+


Attachments
Patch to fix aaaa-filter patch (1.05 KB, patch)
2023-02-07 09:47 UTC, Jaap Akkerhuis
jaap: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description void 2023-02-05 14:48:05 UTC
Hello,

Temporary workaround is to disable the AAAA option (it's not enabled by default)

system:
00:00:01] Makefile datestamp: -rw-r--r--  1 root  wheel  4417 Jan 19 12:32 /usr/ports/dns/unbound/Makefile
[00:00:01] Ports top last git commit: bcc7c435a
[00:00:01] Ports top unclean checkout: no
[00:00:01] Port dir last git commit: 6731a7881
[00:00:01] Port dir unclean checkout: no
[00:00:01] Poudriere version: poudriere-git-3.3.99.20220831
[00:00:01] Host OSVERSION: 1301000
[00:00:01] Jail OSVERSION: 1301000

dns/unbound fails to build in patch phase in poudriere.

####
[00:00:03] ===> Fetching all distfiles required by unbound-1.17.1_1 for building
[00:00:03] ===>  Extracting for unbound-1.17.1_1
[00:00:03] => SHA256 Checksum OK for unbound-1.17.1.tar.gz.
[00:00:03] ===========================================================================
[00:00:03] =======================<phase: patch-depends  >============================
[00:00:03] ===== env: USE_PACKAGE_DEPENDS_ONLY=1 USER=root UID=0 GID=0
[00:00:03] ===========================================================================
[00:00:03] =======================<phase: patch          >============================
[00:00:03] ===== env: NO_DEPENDS=yes USER=root UID=0 GID=0
[00:00:03] ===>  Patching for unbound-1.17.1_1
[00:00:03] /bin/cat /wrkdirs/usr/ports/dns/unbound/work/unbound-1.17.1/contrib/aaaa-filter-iterator.patch | /usr/bin/patch -d /wrkdirs/usr/ports/dns/unbound/work/unbound-1.17.1 -p1 -s
[00:00:03] 1 out of 1 hunks failed--saving rejects to iterator/iter_utils.c.rej
[00:00:03] *** Error code 1
[00:00:03] 
[00:00:03] Stop.
[00:00:03] make: stopped in /usr/ports/dns/unbound
###
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-02-06 13:09:26 UTC
^Triage: simplify title
Comment 2 Jaap Akkerhuis 2023-02-07 09:47:31 UTC
Created attachment 239964 [details]
Patch to fix aaaa-filter patch

This patch will fixes the build.

Let me know whether this fixes the problem so I can propose this to the upstream
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-02-07 15:09:12 UTC
(In reply to Jaap Akkerhuis from comment #2)
It builds fine with AAAA option ON. 

Thanks!
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-02-07 15:26:51 UTC
(In reply to Fernando Apesteguía from comment #3)
2023Q1 is also affected.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-02-07 15:28:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2272e34787c3e6839841c0e4ea919b569dbb5cfc

commit 2272e34787c3e6839841c0e4ea919b569dbb5cfc
Author:     Jaap Akkerhuis <jaap@NLnetLabs.nl>
AuthorDate: 2023-02-07 13:13:09 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-02-07 15:23:14 +0000

    dns/unbound: fix build with AAAA option ON

    PR:             269337
    Reported by:    void@f-m.fm
    MFH:            2023Q1 (build fix)

 dns/unbound/Makefile                                          |  2 +-
 .../files/patch-contrib_aaaa-filter-iterator.patch (new)      | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-02-07 15:33:13 UTC
A commit in branch 2023Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b4f7886cf0032d73980c1cb49e9c7beb0da0a92c

commit b4f7886cf0032d73980c1cb49e9c7beb0da0a92c
Author:     Jaap Akkerhuis <jaap@NLnetLabs.nl>
AuthorDate: 2023-02-07 13:13:09 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-02-07 15:27:22 +0000

    dns/unbound: fix build with AAAA option ON

    PR:             269337
    Reported by:    void@f-m.fm
    MFH:            2023Q1 (build fix)

    (cherry picked from commit 2272e34787c3e6839841c0e4ea919b569dbb5cfc)

 dns/unbound/Makefile                                          |  3 ++-
 .../files/patch-contrib_aaaa-filter-iterator.patch (new)      | 11 +++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2023-02-07 15:33:20 UTC
Committed,

Thanks!
Comment 8 void 2023-02-07 16:04:13 UTC
(In reply to Jaap Akkerhuis from comment #2)

I confirm it works, many thanks :D