Bug 269453 - devel/libpthread-stubs: remove port
Summary: devel/libpthread-stubs: remove port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: needs-qa
Depends on: 269462 269463 269464 269465 269466 269467 269468 269469
Blocks:
  Show dependency tree / graph
 
Reported: 2023-02-10 03:21 UTC by Jan Beich
Modified: 2023-03-12 15:14 UTC (History)
3 users (show)

See Also:
ashish: maintainer-feedback+

Attachments
v1 (apply via "git am") (3.74 KB, patch)
2023-03-01 16:00 UTC, Jan Beich 		no flags Details | Diff
v1 (apply via "git am") (3.79 KB, patch)
2023-03-01 16:08 UTC, Jan Beich 		jbeich: maintainer-approval? (ashish)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2023-02-10 03:21:08 UTC 
libpthread-stubs is no longer used unconditionally in many upstream projects, and FreeBSD deprecated -pthread since ports c560a8562508. New ports shouldn't be using this and the few old ports can be easily patched.

See also https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/193
Comment 1 Jan Beich freebsd_committer freebsd_triage 2023-02-10 03:31:34 UTC 
Looking at https://repology.org/project/libpthread-stubs/versions it seems the package is absent at least on Arch (except AUR), Fedora, OpenBSD, PkgSrc, Void.
Comment 2 Gleb Popov freebsd_committer freebsd_triage 2023-02-11 19:28:11 UTC 
Does this failure have something to do with this bug?

https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/p58633340e9ed_s5636590214/logs/efl-1.26.3_3.log
Comment 3 Jan Beich freebsd_committer freebsd_triage 2023-02-11 19:48:58 UTC 
(In reply to Gleb Popov from comment #2)
Nothing that can affect devel/efl (e.g., bug 269462) has landed so far.

Can you reproduce on FreeBSD < 14? If not see bug 265425 causing https://pkg-status.freebsd.org/builds/default:default:main-amd64:p58633340e9ed_s5636590214:beefy18#new_failed
For example, -Wint-conversion bustage is caused by https://github.com/llvm/llvm-project/commit/7068aa98412a
Comment 4 Jan Beich freebsd_committer freebsd_triage 2023-03-01 16:00:29 UTC 
Created attachment 240507 [details]
v1 (apply via "git am")

I'd like to remove the port before 2023Q2 branches in order to simplify QA when doing MFHs in future.

Please, don't discard the commit message within the patch. It documents the rationale better than comment 0.
Comment 5 Jan Beich freebsd_committer freebsd_triage 2023-03-01 16:08:22 UTC 
Created attachment 240509 [details]
v1 (apply via "git am")

Forgot to add "Inspired by" in the commit message.
Comment 6 Ashish SHUKLA freebsd_committer freebsd_triage 2023-03-12 15:03:35 UTC 
Looks good to me. Please go ahead, and commit.

Sorry for the delay.

Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-03-12 15:14:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=aa72a65245df6bf0e11f1d46ba1bf3131adb6aab

commit aa72a65245df6bf0e11f1d46ba1bf3131adb6aab
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-02-10 13:55:39 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-03-12 15:12:59 +0000

    devel/libpthread-stubs: remove port

    libpthread-stubs >= 0.4 isn't granular: checks too few or often unused
    pthread symbols. On FreeBSD it always added -pthread even if pthread
    stubs libc would be enough. Consumers usually avoid libpthread-stubs
    dependency on Linux, duplicating the logic. So, remove the wrapper.

    PR:             269453
    See also:       https://gitlab.freedesktop.org/xorg/lib/pthread-stubs/-/issues/2
    Inspired by:    Arch, Fedora, OpenBSD, PkgSrc, Void
    Approved by:    ashish (maintainer)

 MOVED                                   |  1 +
 devel/Makefile                          |  1 -
 devel/libpthread-stubs/Makefile (gone)  | 19 -------------------
 devel/libpthread-stubs/distinfo (gone)  |  3 ---
 devel/libpthread-stubs/pkg-descr (gone) |  9 ---------
 5 files changed, 1 insertion(+), 32 deletions(-)