Bug 269601 - multimedia/libmediainfo: Current version in tree breaks consumers
Summary: multimedia/libmediainfo: Current version in tree breaks consumers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-16 21:40 UTC by Daniel Engberg
Modified: 2023-03-13 13:49 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
0001-multimedia-libmediainfo-Re-enable-creating-MediaInfo.patch (1.83 KB, patch)
2023-03-08 09:12 UTC, Michiel van Baak Jansen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-03-02 04:12:32 UTC
No need to revert these commits.

I guess we only need to remove "--disable-dll" which is newly added in this update (from 22.09 to 22.12).
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-03-02 21:53:29 UTC
Given your response it seems you haven't tested if that fixes the issue? Is there any technical reason why we can't move to CMake like most other repos packaging mediainfo project which also seems more robust?
Comment 3 Michiel van Baak Jansen 2023-03-07 09:58:41 UTC
(In reply to Daniel Engberg from comment #2)
Can we please go forward with the changes you proposed, which were tested by me, and which will fix the issue? please?

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268709#c7
Comment 4 Michiel van Baak Jansen 2023-03-08 09:12:31 UTC
Created attachment 240663 [details]
0001-multimedia-libmediainfo-Re-enable-creating-MediaInfo.patch

Attached patch removes the option `--disable-dll`
This option was NOT present before, and it breaks sonarr

Since the whole discussion about make vs cmake is taking its time, please commit this small update as it unbreaks consumers.
Comment 5 Michiel van Baak Jansen 2023-03-08 09:15:41 UTC
(In reply to Daniel Engberg from comment #2)

I have tested it, see attached patch.
Confirmed to unbreak sonarr v3 in my setup (13.1 amd64)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-03-13 10:03:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=23f2da840837311b148a38b5bbe60d0dcc51141a

commit 23f2da840837311b148a38b5bbe60d0dcc51141a
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-03-13 08:04:52 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-03-13 10:02:54 +0000

    multimedia/mediainfo: Revert to previous commit

    Last commit by maintainer broke users of mediainfo, revert related
    libraries prior to this change
    This retains changes to WWW

    PR:             268709, 269601
    Reported by:    Michiel van Baak Jansen <michiel@vanbaak.eu>
    Approved by:    portmgr (blanket, maintainer timeout: 3+ weeks)
    Fixes:          23e0e7b

 multimedia/mediainfo/Makefile | 19 ++++++++++++-------
 multimedia/mediainfo/distinfo |  6 +++---
 2 files changed, 15 insertions(+), 10 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-03-13 10:03:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0194336dea50b97cf44e51f1991abf785be34caa

commit 0194336dea50b97cf44e51f1991abf785be34caa
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-03-13 07:50:57 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-03-13 10:02:54 +0000

    multimedia/libmediainfo: Revert to previous commit

    Last commit by maintainer broke users of mediainfo, revert related
    libraries prior to this change
    This retains changes to WWW and pkg-descr and removal of CXXFLAGS

    PR:             268709, 269601
    Reported by:    Michiel van Baak Jansen <michiel@vanbaak.eu>
    Approved by:    portmgr (blanket, maintainer timeout: 3+ weeks)
    Fixes:          93d0a11

 multimedia/libmediainfo/Makefile  | 31 +++++++++++++++++--------------
 multimedia/libmediainfo/distinfo  |  6 +++---
 multimedia/libmediainfo/pkg-plist |  9 +++++++--
 3 files changed, 27 insertions(+), 19 deletions(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-03-13 10:04:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=90dc81600699c2e7a9918bc641e21d3326af490e

commit 90dc81600699c2e7a9918bc641e21d3326af490e
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-03-13 07:32:47 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-03-13 10:02:54 +0000

    multimedia/libzen: Revert to previous commit

    Last commit by maintainer broke users of mediainfo, revert related
    libraries prior to this change
    This retains changes to WWW and pkg-descr

    PR:             268709, 269601
    Reported by:    Michiel van Baak Jansen <michiel@vanbaak.eu>
    Approved by:    portmgr (blanket, maintainer timeout: 3+ weeks)
    Fixes:          23e0c77

 multimedia/libzen/Makefile  | 25 +++++++++++++------------
 multimedia/libzen/distinfo  |  6 +++---
 multimedia/libzen/pkg-plist | 13 +++++--------
 3 files changed, 21 insertions(+), 23 deletions(-)
Comment 9 Michiel van Baak Jansen 2023-03-13 13:49:34 UTC
(In reply to commit-hook from comment #7)
Thank you.

I tested it with this latest commit, and I can confirm sonarr works again.