Created attachment 240212 [details] Patch for mongo-c-driver * Use upstream release archive as recommended by Porters Handbook * Remove cyrus-sasl2 from LIB_DEPENDS * Use framework helpers when possible * Rearrange Makefile to better follow Porters Handbook and easier readability * Don't install unnecessary files in share directory Compile tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist) Poudriere testport OK 12.3-RELEASE (amd64) Poudriere testport OK 13.1-RELEASE (i386)
Comment on attachment 240212 [details] Patch for mongo-c-driver Well: propably I'm not superhero of porter's book. I'm still learning...
My intention was to make it more compliant and make maintainership easier, sorry if it came across as something else. If you're fine with the changes please set maintainer-feedback flag to +.
I was setting "+" flag on patch during my last comment
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=09dc34631b1ec320ea53b44cf8a5389bc503d02f commit 09dc34631b1ec320ea53b44cf8a5389bc503d02f Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2023-02-20 21:15:02 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2023-02-20 21:23:58 +0000 devel/mongo-c-driver: Rework port * Use upstream release archive as recommended by Porters Handbook * Remove cyrus-sasl2 from LIB_DEPENDS * Use framework helpers when possible * Rearrange Makefile to better follow Porters Handbook and easier readability * Don't install unnecessary files in share directory PR: 269625 Reviewed by: Krzysztof <ports@bsdserwis.com> (maintainer) devel/mongo-c-driver/Makefile | 74 ++++++++++++---------- devel/mongo-c-driver/distinfo | 6 +- ..._libmongoc_src_mongoc_mongoc-counters-private.h | 6 +- devel/mongo-c-driver/pkg-plist | 20 ++---- 4 files changed, 50 insertions(+), 56 deletions(-)
Committed, thanks