Bug 269720 - net/freerdp: 2.10.0 build fail with libressl
Summary: net/freerdp: 2.10.0 build fail with libressl
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Felix Palmen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-20 16:06 UTC by Ivan Rozhuk
Modified: 2023-03-23 09:34 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (vvd)

Attachments
patch (1.30 KB, patch)
2023-02-20 16:06 UTC, Ivan Rozhuk 		rozhuk.im: maintainer-approval?
Details | Diff
Disable sha3 and shake hashes for libressl (1.02 KB, patch)
2023-03-19 23:51 UTC, Vladimir Druzenko 		vvd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2023-02-21 15:28:03 UTC 
I tend to wait for the final decision in upstream.
Comment 2 Ivan Rozhuk 2023-03-19 11:04:36 UTC 
Upstream is done.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2023-03-19 12:26:21 UTC 
(In reply to Ivan Rozhuk from comment #2)
This patch: https://github.com/FreeRDP/FreeRDP/commit/498ddbf23e520fbff6c96a3c4bd4c6b2534529c4 ?
Comment 4 Ivan Rozhuk 2023-03-19 19:31:22 UTC 
(In reply to VVD from comment #3)

Yes, but I did not test it.
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2023-03-19 23:51:22 UTC 
Created attachment 240997 [details]
Disable sha3 and shake hashes for libressl

Check, plz, patch.
Comment 6 Ivan Rozhuk 2023-03-20 10:23:34 UTC 
Build OK.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-03-23 09:33:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=353bb5fa82ac9363e69e53085d68cfc48a0c33e3

commit 353bb5fa82ac9363e69e53085d68cfc48a0c33e3
Author:     VVD <vvd@unislabs.com>
AuthorDate: 2023-03-19 23:51:00 +0000
Commit:     Felix Palmen <zirias@FreeBSD.org>
CommitDate: 2023-03-23 09:28:53 +0000

    net/freerdp: Fix build with LibreSSL

    Disable sha3 and shake hashes for libressl

    PR:             269720
    Approved by:    tcberner (mentor, implicit: libressl)

 net/freerdp/Makefile | 3 +++
 net/freerdp/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 8 Felix Palmen freebsd_committer freebsd_triage 2023-03-23 09:34:01 UTC 
Committed, thanks!