Created attachment 240392 [details] patch v1 Hi, I have created a patch to update nextcloudclient. Some changes where required: - Upstream decided to make webengine mandatory except on MacOS. I have patched back the code to allow us to disable it anyway - I have updated the WEBENGINE option description to describe what webengine is used for, so users disabling it can guess what functionality they are disabling. - Added USES=kde:5 and USE_KDE=archive to properly require a new dependency Everything looks fine on my system at runtime and in poudriere with supported FreeBSD versions, I tested both with and without webengine support in poudriere.
Created attachment 240749 [details] Update v2 Hi, New version was released in the while, attaching revised patch.
Hi, thanks a lot for your work. Could you please do me a vavour and commit the patch for me since Im currently ill and I would have to wait for some more days otherwise. Thanks in advance.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d196d2e2510aedbfd1134d5358ab0e961f12e964 commit d196d2e2510aedbfd1134d5358ab0e961f12e964 Author: Guido Falsi <madpilot@FreeBSD.org> AuthorDate: 2023-03-12 09:43:51 +0000 Commit: Guido Falsi <madpilot@FreeBSD.org> CommitDate: 2023-03-12 09:43:51 +0000 deskutils/nextcloudclient: Update to 3.7.4 - Improve WEBENGINE option description PR: 269809 Approved by: mr (maintainer) deskutils/nextcloudclient/Makefile | 9 ++--- deskutils/nextcloudclient/distinfo | 6 ++-- .../files/patch-src_CMakeLists.txt (new) | 41 ++++++++++++++++++++++ 3 files changed, 49 insertions(+), 7 deletions(-)
(In reply to Michael Reifenberger from comment #2) Thanks for the approval! I committed it. Take care, and I hope you get well soon!