Bug 269812 - games/trigger-rally: fix build with lld 15 on i386
Summary: games/trigger-rally: fix build with lld 15 on i386
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-24 21:58 UTC by Alfonso S. Siciliano
Modified: 2023-03-01 17:48 UTC (History)
1 user (show)

See Also:

Attachments
cd ports/games/trigger-rally; git diff --staged > ../`make -VPKGNAME`.diff (1010 bytes, patch)
2023-02-24 21:58 UTC, Alfonso S. Siciliano 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alfonso S. Siciliano freebsd_committer freebsd_triage 2023-02-24 21:58:50 UTC 
Created attachment 240394 [details]
cd ports/games/trigger-rally; git diff --staged > ../`make -VPKGNAME`.diff

Problem/Discussion in ports@:
https://lists.freebsd.org/archives/freebsd-ports/2023-February/003457.html

Solution:
https://lists.freebsd.org/archives/freebsd-ports/2023-February/003458.html

Extra discussion PR: bug #268495

Example solution:
https://cgit.freebsd.org/ports/diff/audio/openal-soft/Makefile?id=145ca5487348

Tested in virtualbox FreeBSD 14 CURRENT i386.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2023-02-24 21:58:50 UTC 
Maintainer informed via mail
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-02-25 18:13:45 UTC 
LGTM!

You can land this.

Minor thing: try to use a different *name* for the attachment... this one is a bit weird :-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-03-01 17:47:41 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ef0c6dcb3d0725c090609342ce8239427d39ce3b

commit ef0c6dcb3d0725c090609342ce8239427d39ce3b
Author:     Alfonso S. Siciliano <asiciliano@FreeBSD.org>
AuthorDate: 2023-03-01 17:39:38 +0000
Commit:     Alfonso S. Siciliano <asiciliano@FreeBSD.org>
CommitDate: 2023-03-01 17:46:10 +0000

    games/trigger-rally: fix build with lld 15 on i386

    ld: error: ../bin/trigger-rally:(.eh_frame+0xa40b): internal linker
    error: wrote incorrect addend value 0x4A042E4A instead of 0x0 for
    dynamic relocation R_386_32 at offset 0x429B53 against symbol
    __gxx_personality_v0

    PR:             269812
    Reported by:    pkg-fallout
    Approved by:    fernape

 games/trigger-rally/Makefile | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
Comment 4 Alfonso S. Siciliano freebsd_committer freebsd_triage 2023-03-01 17:48:09 UTC 
Committed!