Bug 269814 - x11/kitty: add void to functions with empty parameter list
Summary: x11/kitty: add void to functions with empty parameter list
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-24 22:21 UTC by Trond Endrestøl
Modified: 2023-03-10 11:18 UTC (History)
1 user (show)

See Also:

Attachments
The individual patches in Git diff format (9.96 KB, patch)
2023-02-24 22:22 UTC, Trond Endrestøl 		no flags Details | Diff
All patches rolled into one (6.72 KB, patch)
2023-02-24 22:23 UTC, Trond Endrestøl 		no flags Details | Diff
Patch to the ports tree (10.74 KB, patch)
2023-02-25 17:06 UTC, Fernando Apesteguía 		fernape: maintainer-approval?
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Trond Endrestøl 2023-02-24 22:21:22 UTC 
Clang 15 enforces the use of void in an otherwise empty parameter list.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2023-02-24 22:21:22 UTC 
Maintainer informed via mail
Comment 2 Trond Endrestøl 2023-02-24 22:22:18 UTC 
Created attachment 240396 [details]
The individual patches in Git diff format
Comment 3 Trond Endrestøl 2023-02-24 22:23:00 UTC 
Created attachment 240397 [details]
All patches rolled into one
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-02-25 17:06:13 UTC 
Created attachment 240408 [details]
Patch to the ports tree

Hi Trond,

Thanks for the patch. It applies to kitty's code itself so it would be a good idea to report it upstream. I attached a new patch that applies to the actual port.

Cheers.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2023-03-10 11:18:39 UTC 
Committed,

Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-03-10 11:18:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=75c3b1ee6f8398a8c4dedbda90611048ccd101c8

commit 75c3b1ee6f8398a8c4dedbda90611048ccd101c8
Author:     Trond Endrestol <Trond.Endrestol@ximalas.info>
AuthorDate: 2023-02-25 16:58:44 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-03-10 11:13:50 +0000

    x11/kitty: add void to functions with empty parameter list

    Clang 15 enforces the use of void in an otherwise empty parameter list.

    PR:             269814
    Reported by:    Trond.Endrestol@ximalas.info
    Approved by:    alexis.praga@free.fr (maintainer timeout > 2 weeks)

 x11/kitty/files/patch-glfw_dbus__glfw.c (new)        | 20 ++++++++++++++++++++
 x11/kitty/files/patch-glfw_wl__window.c (new)        | 17 +++++++++++++++++
 .../files/patch-kittens_choose_unix__compat.c (new)  | 11 +++++++++++
 x11/kitty/files/patch-kitty_colors.c (new)           | 20 ++++++++++++++++++++
 x11/kitty/files/patch-kitty_cursor.c (new)           | 11 +++++++++++
 x11/kitty/files/patch-kitty_data-types.c (new)       | 19 +++++++++++++++++++
 x11/kitty/files/patch-kitty_gl-wrapper.h (new)       | 20 ++++++++++++++++++++
 x11/kitty/files/patch-kitty_gl.c (new)               | 11 +++++++++++
 x11/kitty/files/patch-kitty_glfw.c (new)             | 20 ++++++++++++++++++++
 x11/kitty/files/patch-kitty_graphics.c (new)         | 11 +++++++++++
 x11/kitty/files/patch-kitty_line.c (new)             | 11 +++++++++++
 x11/kitty/files/patch-kitty_mouse.c (new)            | 20 ++++++++++++++++++++
 x11/kitty/files/patch-kitty_shaders.c (new)          | 20 ++++++++++++++++++++
 x11/kitty/files/patch-kitty_state.c (new)            | 11 +++++++++++
 14 files changed, 222 insertions(+)