Bug 269822 - editors/uemacs: Fix build with Clang 15
Summary: editors/uemacs: Fix build with Clang 15
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL: https://www.freshports.org/editors/ue...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-25 11:29 UTC by mail
Modified: 2023-03-03 21:33 UTC (History)
2 users (show)

See Also:

Attachments
Use -Wno-int-conversion flag (428 bytes, patch)
2023-02-25 11:29 UTC, mail 		mail: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mail 2023-02-25 11:29:59 UTC 
Created attachment 240406 [details]
Use -Wno-int-conversion flag

As reported by José Pérez on the freebsd-ports list, editors/uemacs fails to build on 14.0-CURRENT 1400079, due to Clang 15 treating implicit pointer/integer conversions as errors.

This patch uses the -Wno-int-conversion compiler flag as suggested by Dimitry Andric, treating the conversion as a warning like previous versions of Clang.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-03-02 16:25:31 UTC 
Strongly consider removing -Werror instead of adding more warning flags.
Comment 2 mail 2023-03-03 04:42:13 UTC 
(In reply to Robert Clausecker from comment #1)

I don't believe -Werror is set anywhere in the uemacs source, nor the port's Makefile.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-03-03 09:32:15 UTC 
(In reply to mail from comment #2)

Ah yes I see, thank you for the explanation.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-03-03 21:31:56 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3c426844b505ca60455f52608fe27dceef5e9d82

commit 3c426844b505ca60455f52608fe27dceef5e9d82
Author:     Andrew Clarke <mail@ozzmosis.com>
AuthorDate: 2023-03-02 16:27:05 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-03-03 21:31:09 +0000

    editors/uemacs: fix build with LLVM 15

    Silence -Wint-conversion to have the build succeed.

    PR:             269822
    Approved by:    eduardo (mentor)
    Differential Revision: https://reviews.freebsd.org/D38871

 editors/uemacs/Makefile | 2 ++
 1 file changed, 2 insertions(+)
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-03-03 21:33:20 UTC 
Thank you for your contribution.