Bug 269887 - x11/wev: checksum mismatch for 0be512fb7058.patch
Summary: x11/wev: checksum mismatch for 0be512fb7058.patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-28 22:57 UTC by Dan Kotowski
Modified: 2023-02-28 23:06 UTC (History)
0 users

See Also:
jbeich: maintainer-feedback+
jbeich: merge-quarterly+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Kotowski 2023-02-28 22:57:36 UTC
# make checksum
===>  License MIT accepted by the user
===>   wev-1.0.0_2 depends on file: /usr/local/sbin/pkg - found
=> 0be512fb7058.patch doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch https://git.sr.ht/~sircmpwn/wev/commit/0be512fb7058.patch
0be512fb7058.patch                                    1148  B   11 MBps    00s
===> Fetching all distfiles required by wev-1.0.0_2 for building
=> SHA256 Checksum OK for wev-1.0.0.tar.gz.
=> SHA256 Checksum mismatch for 0be512fb7058.patch.
===>  Refetch for 1 more times files:  0be512fb7058.patch
===>  License MIT accepted by the user
===>   wev-1.0.0_2 depends on file: /usr/local/sbin/pkg - found
=> 0be512fb7058.patch doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch https://git.sr.ht/~sircmpwn/wev/commit/0be512fb7058.patch
0be512fb7058.patch                                    1148  B   12 MBps    00s
===> Fetching all distfiles required by wev-1.0.0_2 for building
===>  License MIT accepted by the user
===>   wev-1.0.0_2 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by wev-1.0.0_2 for building
=> SHA256 Checksum OK for wev-1.0.0.tar.gz.
=> SHA256 Checksum mismatch for 0be512fb7058.patch.
===>  Giving up on fetching files:  0be512fb7058.patch
Make sure the Makefile and distinfo file (/usr/ports/x11/wev/distinfo)
are up to date.  If you are absolutely sure you want to override this
check, type "make NO_CHECKSUM=yes [other args]".
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/x11/wev
*** Error code 1

Stop.
make: stopped in /usr/ports/x11/wev

# shasum -a256 /usr/ports/distfiles/0be512fb7058.patch
c6aa3fa17dd166ee881cdda1a0947ce7c20877393bec296194b260c567ebcacd  /usr/ports/distfiles/0be512fb7058.patch

# grep 0be512fb7058.patch distinfo
SHA256 (0be512fb7058.patch) = 91e09d0bcc36f8f33b255f1e9e61b7a05f79942809f5079fb4ff767df07d64cd
SIZE (0be512fb7058.patch) = 1148

# cat /usr/ports/distfiles/0be512fb7058.patch
From 0be512fb705831b55020e1eaf86eedba0eae4a75 Mon Sep 17 00:00:00 2001
From: Ronan Pigott <rpigott@berkeley.edu>
Date: Tue, 7 Jul 2020 02:32:40 -0700
Subject: [PATCH] remember to close and unmap buffer after drawing

So when you open wev and wiggle it about a bit in an interactive
resize it eats a bunch of memory before dieing of too many open files.
It looks like it was just forgotten to clean up the wl_buffer when
we're done. I think this is all that's needed.
---
 wev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/wev.c b/wev.c
index 67df920..8a90917 100644
--- a/wev.c
+++ b/wev.c
@@ -531,6 +531,7 @@ static struct wl_buffer *create_buffer(struct wev_state *state) {
        struct wl_buffer *buffer = wl_shm_pool_create_buffer(pool, 0,
                        state->width, state->height, stride, WL_SHM_FORMAT_XRGB8888);
        wl_shm_pool_destroy(pool);
+       close(fd);

        for (int y = 0; y < state->height; ++y) {
                for (int x = 0; x < state->width; ++x) {
@@ -541,6 +542,7 @@ static struct wl_buffer *create_buffer(struct wev_state *state) {
                        }
                }
        }
+       munmap(data, size);

        wl_buffer_add_listener(buffer, &wl_buffer_listener, NULL);

--
2.34.7
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-02-28 23:05:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4a59358fa9d05ff029021dfc0b078affb6c5fdad

commit 4a59358fa9d05ff029021dfc0b078affb6c5fdad
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-02-28 23:04:34 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-02-28 23:04:36 +0000

    x11/wev: unbreak fetch due to Git upgrade

    => SHA256 Checksum mismatch for 0be512fb7058.patch.

    -2.34.5
    +2.34.7

    PR:             269887
    Reported by:    Dan Kotowski

 x11/wev/distinfo | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-02-28 23:05:50 UTC
A commit in branch 2023Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=027bf06810f6099284a6c87d920b29cb163bbc34

commit 027bf06810f6099284a6c87d920b29cb163bbc34
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-02-28 23:04:34 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-02-28 23:05:04 +0000

    x11/wev: unbreak fetch due to Git upgrade

    => SHA256 Checksum mismatch for 0be512fb7058.patch.

    -2.34.5
    +2.34.7

    PR:             269887
    Reported by:    Dan Kotowski

    (cherry picked from commit 4a59358fa9d05ff029021dfc0b078affb6c5fdad)

 x11/wev/distinfo | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Jan Beich freebsd_committer freebsd_triage 2023-02-28 23:06:17 UTC
Thanks for reporting. See also https://todo.sr.ht/~sircmpwn/git.sr.ht/368