Bug 269896 - net-mgmt/pmacct: update to 1.7.8 and fix latest clang version deprecation
Summary: net-mgmt/pmacct: update to 1.7.8 and fix latest clang version deprecation
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-01 14:16 UTC by Olivier Cochard
Modified: 2023-03-04 17:31 UTC (History)
1 user (show)

See Also:
pi: maintainer-feedback+

Attachments
patch to update (7.35 KB, patch)
2023-03-01 14:16 UTC, Olivier Cochard 		no flags Details | Diff
my current patch (19.03 KB, patch)
2023-03-01 14:37 UTC, Kurt Jaeger 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Cochard freebsd_committer freebsd_triage 2023-03-01 14:16:34 UTC 
Created attachment 240504 [details]
patch to update

Update to last version, some fixes about:
- "error: a function definition without a prototype is deprecated"
- "error: variable set but not used"
- "error: non initialized variable"

it compiles but need more test.
Comment 1 Mina Galić freebsd_triage 2023-03-01 14:29:18 UTC 
are these patches obtained from, or submitted to upstream?
Comment 2 Olivier Cochard freebsd_committer freebsd_triage 2023-03-01 14:30:01 UTC 
I've wrote them.
And started to create a Pull-Request:
https://github.com/pmacct/pmacct/pull/669
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2023-03-01 14:37:23 UTC 
Created attachment 240505 [details]
my current patch

This is my version of the patch...
Comment 4 Olivier Cochard freebsd_committer freebsd_triage 2023-03-01 18:25:52 UTC 
(In reply to Kurt Jaeger from comment #3)
Your patches seems a lot smarter than mine :-)
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2023-03-01 18:39:00 UTC 
Thanks. Patches are still untested, I need to find time to do some test-runs.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-03-04 17:31:25 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8e8ea047aa531a7825cf293ad76a2defca9efd5d

commit 8e8ea047aa531a7825cf293ad76a2defca9efd5d
Author:     Kurt Jaeger <pi@FreeBSD.org>
AuthorDate: 2023-03-04 17:27:24 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2023-03-04 17:27:24 +0000

    net-mgmt/pmacct: update 1.7.7 -> 1.7.8

    - some new patches needed to make it build

    PR:             269896
    Reported-by:    olivier
    Sponsored-by:   Nepustil.net
    Changes:        https://github.com/pmacct/pmacct/releases/tag/v1.7.8

 net-mgmt/pmacct/Makefile                           |  7 ++-
 net-mgmt/pmacct/distinfo                           |  6 +-
 net-mgmt/pmacct/files/patch-Makefile.in            |  4 +-
 net-mgmt/pmacct/files/patch-configure.ac (gone)    | 20 ------
 net-mgmt/pmacct/files/patch-src_bgp_bgp.c          |  4 +-
 .../pmacct/files/patch-src_bgp_bgp__lookup.c (new) | 20 ++++++
 .../files/patch-src_external__libs_Makefile.am     | 73 ++++++++++++++++++++--
 .../pmacct/files/patch-src_imt__plugin.h (new)     | 11 ++++
 net-mgmt/pmacct/files/patch-src_kafka__plugin.c    |  4 +-
 net-mgmt/pmacct/files/patch-src_memory.c (new)     | 11 ++++
 net-mgmt/pmacct/files/patch-src_net__aggr.h (new)  | 11 ++++
 .../files/patch-src_nfprobe__plugin_netflow9.c     |  4 +-
 net-mgmt/pmacct/files/patch-src_pgsql__plugin.c    |  4 +-
 .../files/patch-src_plugin__cmn__avro.c (new)      | 11 ++++
 net-mgmt/pmacct/files/patch-src_pmacct.c           |  6 +-
 .../files/patch-src_pretag__handlers.c (new)       | 18 ++++++
 .../pmacct/files/patch-src_setproctitle.c (new)    | 24 +++++++
 net-mgmt/pmacct/files/patch-src_sflow.c            |  4 +-
 net-mgmt/pmacct/files/patch-src_sql__common.h      |  4 +-
 net-mgmt/pmacct/files/patch-src_sqlite3__plugin.c  |  4 +-
 net-mgmt/pmacct/files/patch-src_util.c             | 22 ++++++-
 net-mgmt/pmacct/pkg-plist                          |  2 -
 22 files changed, 221 insertions(+), 53 deletions(-)
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2023-03-04 17:31:38 UTC 
Committed, thanks!