Change

* take maintainership
* update PORTVERSION to 1.3
* It seems that the binaries were changed in the archive and I had to change them in the port. When assembling the port, I got errors that the files needed to be replaced with these. This was one of the port build checks.
* removed `pathes` from `files/` because it doesn't build with patches, but builds without patches.
* portlint > looks fine.
* portclippy and portfmt checks
* build in jail 13.1-RELEASE-p6 amd64 was successful. I didn't run the program after build for testing!

Comment 2 Robert Clausecker 2023-03-04 18:44:43 UTC

The binary names were changed in the Makefile patch.  Please restore the patch and adapt it to the new version instead of discarding it.  Changing the binary name is a backwards-incompatible change which we would like to avoid if possible.

The same applies to the config.mk patch.  This patch ensures that the port obeys our own CFLAGS, CPPFLAGS, and LDFLAGS.  By discarding the patches you have broken this functionality.  Please check and revise the patch.

Comment 3 Daniel Engberg 2023-03-05 07:52:10 UTC

Remove LOCAL/dhn and you might as switch from PORTVERSION to DISTVERSION as instructed in Porters Handbook.

You could also just rename the binary and manpage in ports Makefile to avoid patching but I agree that we should stick with simpleirc.

Created attachment 240592 [details]
0001-irc-simpleirc-Update-to-1.3v2.patch

Thank you all for your reply.

I am attaching my updated patch with the following changes:

* removed LOCAL/dhn to go to DISTVERSION.
* removed patch-config.mk because it no longer exists in the archive, its flags are now in the Makefile.
* adapted path-Makefile similar to old patch changes.
* added ${STRIP_CMD} for it to +post-install

Created attachment 240593 [details]
0001-irc-simpleirc-Update-to-1.3v2.patch

Comment 6 commit-hook 2023-03-08 10:19:56 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9a7c9aad1d57fd84c403c2e643bff9a8a098b545

commit 9a7c9aad1d57fd84c403c2e643bff9a8a098b545
Author:     Clockwork6400 <Clockwork6400@protonmail.com>
AuthorDate: 2023-03-05 08:29:02 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-03-08 10:10:17 +0000

    irc/simpleirc: Update to 1.3

    Changelog: https://git.suckless.org/sic/log.html

    PR:             269944

 irc/simpleirc/Makefile                     | 13 ++++---
 irc/simpleirc/distinfo                     |  5 ++-
 irc/simpleirc/files/patch-Makefile         | 59 +++++++++++++++++++-----------
 irc/simpleirc/files/patch-config.mk (gone) | 26 -------------
 4 files changed, 49 insertions(+), 54 deletions(-)

Comment 7 Robert Clausecker 2023-03-08 10:25:40 UTC

Thank you for your contribution.