Bug 269991 - devel/opengrok: depends on deprecated tomcat version
Summary: devel/opengrok: depends on deprecated tomcat version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Don Lewis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-06 09:50 UTC by Yuri
Modified: 2023-03-11 00:14 UTC (History)
0 users

See Also:
truckman: maintainer-feedback+


Attachments
switch to www/tomcat101 dependency (3.18 KB, patch)
2023-03-06 09:50 UTC, Yuri
no flags Details | Diff
update to 1.7.42 and switch to www/tomcat101 (22.73 KB, patch)
2023-03-07 13:15 UTC, Yuri
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri 2023-03-06 09:50:42 UTC
Created attachment 240615 [details]
switch to www/tomcat101 dependency

Currently devel/opengrok with TOMCAT10 option depends on deprecated www/tomcat10:

===>   NOTICE:

This port is deprecated; you may wish to reconsider installing it:

EOLd, potential security issues (https://tomcat.apache.org/tomcat-10.0-eol.html), use www/tomcat101 instead.

It is scheduled to be removed on or after 2023-06-30.

Switch to using www/tomcat101 as suggested.

Not updating PORTREVISION as current setup should still work, but new installs should pull new dependency.
Comment 1 Yuri 2023-03-07 13:15:29 UTC
Created attachment 240635 [details]
update to 1.7.42 and switch to www/tomcat101

Apparently simply switching to tomcat 10.1.x isn't enough as it broke the /api requests, and that was fixed in opengrok 1.7.40.

Updated patch to update opengrok to 1.7.42 (latest in 1.7 branch at the moment) and switch to www/tomcat101.
Comment 2 Don Lewis freebsd_committer freebsd_triage 2023-03-08 23:38:23 UTC
Looks good to me.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-03-09 00:05:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ea1f6587bdd9449a4698f2c01f53f6607e22d568

commit ea1f6587bdd9449a4698f2c01f53f6607e22d568
Author:     Yuri <yuri@aetern.org>
AuthorDate: 2023-03-08 23:55:54 +0000
Commit:     Don Lewis <truckman@FreeBSD.org>
CommitDate: 2023-03-09 00:03:06 +0000

    devel/opengrok: update to 1.7.42, with tomcat101

    www/tomcat10 is deprecated, so switch to www/tomcat101.  This changes
    the /api requests, which requires opengrok 1.7.40.  Upgrade to the
    latest 1.7.x version of opengrok, which is currently 1.7.42.

    PR:             269991

 devel/opengrok/Makefile  |  9 +++----
 devel/opengrok/distinfo  |  6 ++---
 devel/opengrok/pkg-plist | 62 ++++++++++++++++++++++++------------------------
 3 files changed, 39 insertions(+), 38 deletions(-)