Both Alpine and Arch Linux seems to have patches fixing this issue: www/qt5-webengine: Patches available https://github.com/archlinux/svntogit-packages/blob/packages/qt5-webengine/trunk/qt5-webengine-ffmpeg5.patch https://git.alpinelinux.org/aports/tree/community/qt5-qtwebengine/ffmpeg5.patch Reference: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261302#c46
@kai, could you take a look at this? mfg Tobias
(In reply to Tobias C. Berner from comment #1) Thanks for the heads-up. I'm going to take a look into it which will take a while.
Created attachment 240975 [details] qt5-webengine-add-support-for-newer-ffmpeg.patch
Created attachment 240976 [details] ffmpeg6.0-with-av_stream_get_first_dts-symbol.patch
Using the patches [1] from ArchLinux for FFmpeg 5+ compatibility reduces the emitted error messages as reported in bug #261302 comment #44. But there are still some errors: [...] ./../../../../qtwebengine-everywhere-src-5.15.8/src/3rdparty/chromium/media/filters/ffmpeg_demuxer.cc:101:7: error: use of undeclared identifier 'av_stream_get_first_dts'; d id you mean 'av_stream_get_end_pts'? ./../../../../qtwebengine-everywhere-src-5.15.8/src/3rdparty/chromium/media/filters/ffmpeg_demuxer.cc:106:48: error: use of undeclared identifier 'av_stream_get_first_dts'; did you mean 'av_stream_get_end_pts'? [...] If you add the patches [2] for ffmpeg from ArchLinux, which adds the "av_stream_get_first_dts" symbol, the building of www/qt5-webengine suceeds. As far as I can see, the following options would be given at the moment: Option a) - Use the patch (= ffmpeg6.0-with-av_stream_get_first_dts-symbol.patch) for FFmpeg 6.0 - Once FFmpeg 6.0 lands into the ports tree, commit the patch (= qt5-webengine-add-support-for-new-ffmpeg.patch) for www/qt5-webengine as soon as possible and bump the PORTREVISION. Option b) - Switch to the bundled ffmpeg of www/qt5-webengine. What do you (kde@, multimedia@, community) think about it? -- [1] https://github.com/archlinux/svntogit-packages/blob/packages/qt5-webengine/trunk/qt5-webengine-ffmpeg5.patch [2] https://github.com/archlinux/svntogit-packages/blob/packages/ffmpeg/trunk/add-av_stream_get_first_dts-for-chromium.patch
We already have a few ports confirmed to only work with FFmpeg 6.0 after being patched/updated so if my opinion is of any worth I think we can bump it afterwards. If that's deemed acceptable just change from Blocks to Depends on for this bugs report so there aren't any misunderstandings.
..and of course, many thanks looking into this! :)
I'm still on ffmpeg-4.4.3_4,1, but I'm unable to compile qt5-webengine 5.15.8. It dies at the stage of linking libQt5WebEngine.so.5.15.8: /usr/local/bin/ld: .obj/qquickwebengineview.o: in function `QQuickWebEngineViewPrivate::~QQuickWebEngineViewPrivate()': qquickwebengineview.cpp:(.text+0x4a6): undefined reference to `QtWebEngineCore::closingDown()' /usr/local/bin/ld: .obj/qquickwebengineview.o: in function `QQuickWebEngineViewPrivate::bindViewAndWidget(QQuickWebEngineView*, QtWebEngineCore::RenderWidgetHostViewQtDelegateQuick*)': qquickwebengineview.cpp:(.text+0x6ed): undefined reference to `QtWebEngineCore::closingDown()' /usr/local/bin/ld: .obj/qquickwebengineview.o: in function `QQuickWebEngineViewPrivate::releaseProfile()': qquickwebengineview.cpp:(.text+0x845): undefined reference to `QtWebEngineCore::closingDown()' /usr/local/bin/ld: .obj/qquickwebengineview.o: in function `QQuickWebEngineViewPrivate::widgetChanged(QtWebEngineCore::RenderWidgetHostViewQtDelegateQuick*, QtWebEngineCore::RenderWidgetHostViewQtDelegateQuick*)': qquickwebengineview.cpp:(.text+0x3b18): undefined reference to `QtWebEngineCore::closingDown()' Is that related to this bug, or is it a new and different one?
Correction to my previous comment: After updating my ports tree, all of a sudden I AM using ffmpeg 6. I'm trying out the patches now.
(In reply to George Mitchell from comment #9) fyi, https://github.com/freebsd/poudriere/pull/1046
Thanks for the pointer, but I have a case of terminal allergy to poudriere, so fortunately my build should not be subject to the max files problem. (I'm a dyed-in-the-wool fan of portmaster, and updating only when I have to fix a security problem.)
My build failed again, but I've convinced myself it's a different problem than this bug. Once I have a complete build log with MAKE_JOBS_UNSAFE=yes, I'll file a new bug report.
(In reply to George Mitchell from comment #12) Thanks for the all info, especially the fact that portmaster is used. Have you already tried the instructions of the UPDATING entry of 20230306? If already tried, then a new bug report must be created as you already mentioned as the errors aren't related to FFmpeg 6.0.
Thanks for the reminder! Indeed, removing the previous version was what I needed to do, and now everything compiles perfectly. So I confirm that using the patches here does allow compiling with ffmpeg 6.
Hi Kai, Can you have a look at this again as it seems like something is failing :/ https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261302#c69 We're likely to commit FFmpeg 6 soon Can you also supply a patch for ffmpeg that applies on top of jbeich's? That would be a lot easier to commit. Best regards, Daniel
Created attachment 241596 [details] qt5-webengine-complate-patch-based-on-ffmpeg-6.0-v3.patch (In reply to Daniel Engberg from comment #15) Hi Daniel, thanks for the info. As already stated in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261302#c60, multimedia/ffmpeg needs also an additional patch. I've attached a patch (based on my previous two patches) on top of jbeich's actual version (= v3) of the patch for ffmpeg 6.0: - Add the symbol for "av_stream_get_first_dts" to multimedia/ffmpeg - Add support for ffmpeg 5+ for www/qt5-webengine - Bump the PORTREVISION of www/qt5-webengine Please note: My own builder is currently oversubscribed, so I cannot confirm a successful build at this time of writing.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d4d975cffa333bd1b88fcdaf1f0c8f3aa79728b9 commit d4d975cffa333bd1b88fcdaf1f0c8f3aa79728b9 Author: Kai Knoblich <kai@FreeBSD.org> AuthorDate: 2023-04-27 11:22:52 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2023-04-27 12:01:46 +0000 multimedia/ffmpeg: Import compatibility patch for qt5-webengine Add symbol for "av_stream_get_first_dts" to ffmpeg PR: 270209 ...av_stream_get_first_dts-for-qt5-webengine (new) | 35 ++++++++++++++++++++++ 1 file changed, 35 insertions(+)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9400fe7480540a0cdcbc6068fca8d3fc5144322d commit 9400fe7480540a0cdcbc6068fca8d3fc5144322d Author: Kai Knoblich <kai@FreeBSD.org> AuthorDate: 2023-04-27 11:20:21 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2023-04-27 12:01:46 +0000 www/qt5-webengine: Add support for FFmpeg 6 Import patches to fix build with FFmpeg 6 PR: 270209 .../patch-add-support-for-ffmpeg5-and-later (new) | 140 +++++++++++++++++++++ 1 file changed, 140 insertions(+)
Committed, thanks