Bug 270225 - devel/py-jsonschema: Add missing files/folders
Summary: devel/py-jsonschema: Add missing files/folders
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-14 22:58 UTC by Kai Knoblich
Modified: 2023-03-15 11:07 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bofh)


Attachments
py-jsonschema-fix-missing-files.patch (9.70 KB, patch)
2023-03-14 22:58 UTC, Kai Knoblich
kai: maintainer-approval? (bofh)
Details | Diff
pkg-plist.pre (List of files without patch applied) (6.67 KB, text/plain)
2023-03-14 22:59 UTC, Kai Knoblich
no flags Details
pkg-plist.post (List of files after the patch is applied) (3.81 KB, text/plain)
2023-03-14 23:00 UTC, Kai Knoblich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2023-03-14 22:58:39 UTC
Created attachment 240857 [details]
py-jsonschema-fix-missing-files.patch

Hi Moin,

while running QA tests for NetBox 3.4.6, I noticed that some files/folder are missing from devel/py-jsonschema, especially the "schemas/vocabularies" subfolder. See also the attached "pkg-plist.pre" and "pkg-plist.post" files for the detailed differences.

This issue can be remedied thanks to the recently introduced support for the PEP517 build framework.

Attached is a patch that does following changes:

* Switch to PEP517 and get rid of the setuptools workaround
* Add a missing dependency for Python 3.8 packages
* Simplify the test framework by using USE_PYTHON=pytest
* Bump PORTREVISION due changed package content.


QA:
~~~
- poudriere -> OK (12.3-RELEASE amd64 for py37, py38, py39, py310 and py311)


Results of "make test":
~~~~~~~~~~~~~~~~~~~~~~~

> === 6726 passed, 549 skipped in N.NNs ===
Comment 1 Kai Knoblich freebsd_committer freebsd_triage 2023-03-14 22:59:48 UTC
Created attachment 240858 [details]
pkg-plist.pre (List of files without patch applied)
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2023-03-14 23:00:32 UTC
Created attachment 240859 [details]
pkg-plist.post (List of files after the patch is applied)
Comment 3 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2023-03-14 23:18:32 UTC
You are a little late for my today's build. So it will go into tomorrow's build.

Good night. :)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-03-15 11:04:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=34cd65b8b1112bc99ed646166024ab624a3f4c0a

commit 34cd65b8b1112bc99ed646166024ab624a3f4c0a
Author:     Kai Knoblich <kai@FreeBSD.org>
AuthorDate: 2023-03-15 11:02:24 +0000
Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
CommitDate: 2023-03-15 11:03:55 +0000

    devel/py-jsonschema: Fix PLIST

    - Switch to PEP517 and get rid of the setuptools workaround
    - Add a missing dependency for Python 3.8 packages
    - Simplify the test framework by using USE_PYTHON=pytest
    - Bump PORTREVISION due changed package content.

    PR:             270225

 devel/py-jsonschema/Makefile                    | 17 +++---
 devel/py-jsonschema/files/patch-setup.py (gone) | 69 -------------------------
 2 files changed, 10 insertions(+), 76 deletions(-)