Bug 270274 - ports-mgmt/pkg_replace: fails to fetch non-default licensed ports with -F option
Summary: ports-mgmt/pkg_replace: fails to fetch non-default licensed ports with -F option
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-16 21:50 UTC by Tomoaki AOKI
Modified: 2023-03-19 17:22 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (kdeguchi)

Attachments
Update to pkg_replace-20230317 (955 bytes, patch)
2023-03-17 00:15 UTC, Ken DEGUCHI 		kdeguchi: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomoaki AOKI 2023-03-16 21:50:32 UTC 
ports-mgmt/pkg_replace: fails to fetch non-default licensed ports with -F option.
Maybe this would be because "-DBATCH" is unconditionally added to build_args at line 775 for -F option.


The failure mode is as below.

# pkg_replace -c -v -m 'DISABLE_VULNERABILITIES=yes' -N -F graphics/epsonscan2-non-free-plugin
--->  Loading /usr/local/etc/pkg_replace/pkg_replace.conf
--->  Installing 'epsonscan2-non-free-plugin-6.6.40.0_1' from 'graphics/epsonscan2-non-free-plugin'
--->  Fetching '/usr/ports/graphics/epsonscan2-non-free-plugin'
===>  epsonscan2-non-free-plugin-6.6.40.0_1 License EPSON needs confirmation,
but BATCH is defined.
*** Error code 1

Stop.
make: stopped in /usr/ports/graphics/epsonscan2-non-free-plugin
** Command failed (exit code 1): env MAKE_JOBS_NUMBER_LIMIT=12 make DISABLE_VULNERABILITIES=yes -DBATCH checksum
** Fix the problem and try again.
--->  ** [1/1] - 0 done, 0 ignored, 0 skipped, 1 failed, 0 locked
--->  Listing the results (+:done / -:ignored / !:failed)
        ! graphics/epsonscan2-non-free-plugin (build error)
Comment 1 Ken DEGUCHI 2023-03-17 00:15:31 UTC 
Created attachment 240913 [details]
Update to pkg_replace-20230317

(In reply to Tomoaki AOKI from comment #0)

Thanks for your report.

I removed "-DBATCH" from "build_args".
The modified version is now available as "pkg_replace-20230317".
Comment 2 Ken DEGUCHI 2023-03-17 00:26:04 UTC 
Please see bug #270280.
Comment 3 Tomoaki AOKI 2023-03-17 08:41:52 UTC 
(In reply to Ken DEGUCHI from comment #2)

Thanks!
I'll comment on Bug 270280.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-03-19 17:22:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ba35ba3b369ecbaa4b2537d9dedf75dfba7d3809

commit ba35ba3b369ecbaa4b2537d9dedf75dfba7d3809
Author:     Ken DEGUCHI <kdeguchi@sz.tokoha-u.ac.jp>
AuthorDate: 2023-03-17 08:24:38 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-03-19 17:16:41 +0000

    ports-mgmt/pkg_replace: update to 20230317

    ChangeLog: https://github.com/kdeguchi/pkg_replace/releases/tag/20230317

    Fix bug for fetch files (`make -DBATCH checksum` error).

    PR:             270280 270274
    Reported by:    kdeguchi@sz.tokoha-u.ac.jp (maintainer)

 ports-mgmt/pkg_replace/Makefile | 2 +-
 ports-mgmt/pkg_replace/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2023-03-19 17:22:33 UTC 
Updated and fixed in https://cgit.FreeBSD.org/ports/commit/?id=ba35ba3b369ecbaa4b2537d9dedf75dfba7d3809

Thanks!