The attached patch updates tig from 2.5.5 (20220111) to 2.5.8 (20230204). It also fixes a missing dependency. If pcre2 (or pcre) is detected during 'configure', it will enable the pcre library during the build. If so, 'make stage-qa' will complain: Error: /usr/local/bin/tig is linked to /usr/local/lib/libpcre2-posix.so.3 from devel/pcre2 but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libpcre2-posix.so:devel/pcre2 The patch also adds a PCRE option that explicity enables / disables pcre as desired. The default state of the PCRE option is off which is just like how packages are build in a package builder environment where the pcre package is not installed. But I have no problem with having it on by default (committer's discretion). The advantage is that it allows users to search via regexp which is a useful tool. The pcre libs have a friendly BSD3CLAUSE license. While here, tweak some sorting / formatting as hinted by portfmt/portclippy. QA: - poudriere testport (ok - 12-stable/amd64 & i386)
Created attachment 241008 [details] [patch] update tig to 2.5.8, fix stage-qa when pcre/pcre2 installed
Thank you! I committed the patch.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=184c1d6d8bea06f2942c63ace2df4449626dc419 commit 184c1d6d8bea06f2942c63ace2df4449626dc419 Author: John Hein <jcfyecrayz@liamekaens.com> AuthorDate: 2023-07-18 15:14:05 +0000 Commit: Mateusz Piotrowski <0mp@FreeBSD.org> CommitDate: 2023-07-18 15:15:45 +0000 devel/tig: Update to 2.5.8 Apart from the update, the patch also fixes a missing dependency. If pcre2 (or pcre) is detected during 'configure', it will enable the pcre library during the build. If so, 'make stage-qa' will complain: > Error: /usr/local/bin/tig is linked to /usr/local/lib/libpcre2-posix.so.3 from devel/pcre2 but it is not declared as a dependency > Warning: you need LIB_DEPENDS+=libpcre2-posix.so:devel/pcre2 The patch also adds a PCRE option that explicity enables / disables pcre as desired. The default state of the PCRE option is off which is just like how packages are build in a package builder environment where the pcre package is not installed. But I have no problem with having it on by default (committer's discretion). The advantage is that it allows users to search via regexp which is a useful tool. The pcre libs have a friendly BSD3CLAUSE license. While here, tweak some sorting / formatting as hinted by portfmt/portclippy. PR: 270362 devel/tig/Makefile | 14 ++++++++------ devel/tig/distinfo | 6 +++--- 2 files changed, 11 insertions(+), 9 deletions(-)