Bug 270368 - devel/libical: update to 3.0.16
Summary: devel/libical: update to 3.0.16
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hajimu UMEMOTO
URL: https://github.com/libical/libical/re...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-20 17:58 UTC by Hajimu UMEMOTO
Modified: 2023-04-30 13:58 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+
antoine: exp-run+

Attachments
libical-3.0.16.diff (3.36 KB, patch)
2023-03-20 17:58 UTC, Hajimu UMEMOTO 		no flags Details | Diff
libical-3.0.16r2.diff (8.83 KB, patch)
2023-03-23 12:22 UTC, Hajimu UMEMOTO 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajimu UMEMOTO freebsd_committer freebsd_triage 2023-03-20 17:58:46 UTC 
Created attachment 241016 [details]
libical-3.0.16.diff

Update devel/libical to latest version.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2023-03-20 18:01:11 UTC 
Moin moin 

Thanks for taking a look at this. 

Is there any fallout to be expected, or is it a simple patch update with no ABI/API changes?

mfg Tobias
Comment 2 Hajimu UMEMOTO freebsd_committer freebsd_triage 2023-03-20 18:15:22 UTC 
(In reply to Tobias C. Berner from comment #1)

I'm not sure exactly but https://github.com/libical/libical/releases says:

  This release is binary and source compatible with version 3.0.0.
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2023-03-21 05:59:08 UTC 
(In reply to Hajimu UMEMOTO from comment #2)
it also says:
"Note that the libical-glib library is considered unstable; therefore may not be binary compatible with previous releases" 
 :)

I think, an exp-run is in order, and the glib-consumers likely want a PORTREVISION bump after committing.

In the plist
libexec/libical/ical-glib-src-generator sounds like it should be masked by %%GLIB%%. Could you verify?

mfg Tobias
Comment 5 Hajimu UMEMOTO freebsd_committer freebsd_triage 2023-03-23 12:22:51 UTC 
Created attachment 241063 [details]
libical-3.0.16r2.diff
Comment 6 Hajimu UMEMOTO freebsd_committer freebsd_triage 2023-03-23 12:24:49 UTC 
(In reply to Tobias C. Berner from comment #3)

I've updated the patch.
pkg-plist seems to have messed with GLIB for some time.
Comment 7 Hajimu UMEMOTO freebsd_committer freebsd_triage 2023-03-23 12:26:08 UTC 
(In reply to Antoine Brodin from comment #4)

Fixed and updated my patch.
It seems bswap_64 was added after 13.1-RELEASE was out.
Comment 8 Antoine Brodin freebsd_committer freebsd_triage 2023-04-01 06:45:35 UTC 
Exp-run looks fine
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-04-30 13:10:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=095a3512c60c8c62fbe6be687d0dea82cbc4ce4f

commit 095a3512c60c8c62fbe6be687d0dea82cbc4ce4f
Author:     Hajimu UMEMOTO <ume@FreeBSD.org>
AuthorDate: 2023-04-30 13:06:01 +0000
Commit:     Hajimu UMEMOTO <ume@FreeBSD.org>
CommitDate: 2023-04-30 13:08:57 +0000

    devel/libical: update to 3.0.16

    PR:             270368
    Exp-run by:     antoine
    Relnotes:       https://github.com/libical/libical/releases/tag/v3.0.16

 devel/libical/Makefile                             |   4 +-
 devel/libical/distinfo                             |   6 +-
 devel/libical/files/patch-icu68 (gone)             |  29 ------
 .../files/patch-src__libical__icaltz-util.c (new)  |  13 +++
 devel/libical/pkg-plist                            | 101 +++++++++++----------
 5 files changed, 70 insertions(+), 83 deletions(-)